You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/19 17:14:36 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5273: Sv39 MMU driver

xiaoxiang781216 commented on a change in pull request #5273:
URL: https://github.com/apache/incubator-nuttx/pull/5273#discussion_r787967724



##########
File path: arch/risc-v/src/common/riscv_mmu.h
##########
@@ -97,26 +102,65 @@
  *
  ****************************************************************************/
 
-static inline void mmu_enable(uintptr_t pgbase, uint16_t asid)
+static inline uintptr_t satp_reg(uintptr_t pgbase, uint16_t asid)

Review comment:
       should we add prefix mmu_stap_reg

##########
File path: arch/risc-v/src/common/riscv_mmu.c
##########
@@ -43,6 +43,13 @@
  * Private Data
  ****************************************************************************/
 
+#ifdef CONFIG_ARCH_MMU_TYPE_SV39
+static const size_t m_pgt_sizes[] =

Review comment:
       m_gpt_sizes to g_gpt_sizes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org