You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "exceptionfactory (via GitHub)" <gi...@apache.org> on 2024/10/16 03:09:11 UTC

[PR] NIFI-10002 Validate Directory Path in ListFile [nifi]

exceptionfactory opened a new pull request, #9393:
URL: https://github.com/apache/nifi/pull/9393

   # Summary
   
   [NIFI-10002](https://issues.apache.org/jira/browse/NIFI-10002) Adds validation to the evaluated Directory path when performing a listing in the `ListFile` Processor. The validation checks for `null` or a blank string and throws an `IOException` when found.
   
   An empty string is valid constructor argument for `java.io.File` but should never be valid for the `ListFile` Processor as it defaults to the current process working directory. The exception message indicates that the configured expression value for the `Directory` property should be checked. The `Directory` property supports environment variables or other expression language functions, so checking the evaluated expression before listing is necessary to avoid unexpected listing of the current working directory.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-10002 Validate Directory Path in ListFile [nifi]

Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #9393: NIFI-10002 Validate Directory Path in ListFile
URL: https://github.com/apache/nifi/pull/9393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org