[GitHub] [skywalking] hanahmily commented on issue #2987: Adding deadline to gRPC client

[GitBox <gi...@apache.org>]

hanahmily commented on issue #2987: Adding deadline to gRPC client
URL: https://github.com/apache/skywalking/pull/2987#issuecomment-507911635
 
 
   I take a look at your original PR which is different from this one.
   
   The correct approach is to set deadline just before invoking service
   method. If we request steaming 10 times, 10 deadlines should be set to each
   request.
   
   Your approach was to set deadline at stub initial that is the wrong way of
   using deadline
   
   On Wed, Jul 3, 2019, 9:59 AM 吴晟 Wu Sheng <no...@github.com> wrote:
   
   > *@wu-sheng* commented on this pull request.
   >
   > SegmentReport, Remote, and Exporter are all streaming, they are all
   > streaming mode, this setup is the bug I was facing before.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/skywalking/pull/2987?email_source=notifications&email_token=AAO6UWIXRFSD23I4MX6LAADP5QBX7A5CNFSM4H5AT5JKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5KP4TY#pullrequestreview-257228367>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAO6UWOOBYX7HFB5PP2XMBTP5QBX7ANCNFSM4H5AT5JA>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services