[GitHub] [airflow] uranusjr commented on a change in pull request #16301: Fix task retries when they receive sigkill and have retries. Properly handle sigterm too

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #16301:
URL: https://github.com/apache/airflow/pull/16301#discussion_r647378301



##########
File path: airflow/jobs/local_task_job.py
##########
@@ -73,15 +73,8 @@ def _execute(self):
         # pylint: disable=unused-argument
         def signal_handler(signum, frame):
             """Setting kill signal handler"""
-            self.log.error("Received SIGTERM. Terminating subprocesses")
-            self.on_kill()
-            self.task_instance.refresh_from_db()
-            if self.task_instance.state not in State.finished:
-                self.task_instance.set_state(State.FAILED)
-            self.task_instance._run_finished_callback(  # pylint: disable=protected-access
-                error="task received sigterm"
-            )
-            raise AirflowException("LocalTaskJob received SIGTERM signal")
+            self.log.error("LocalTaskJob received SIGTERM signal")
+            self.handle_task_exit(143)

Review comment:
       A comment describing the significance of 143 would be nice 🙂 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org