You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/03/03 22:29:18 UTC
[GitHub] [calcite] vlsi opened a new pull request #2362: Update dependency declarations: adjust api vs implementation, remove unused ones
vlsi opened a new pull request #2362:
URL: https://github.com/apache/calcite/pull/2362
This change brings dependency analysis plugin:
./gradlew buildHealth --no-parallel --no-daemon
Most of the times the suggestions are good, however, there are still issues,
so don't blindly follow the recommendations.
---
The resulting core pom.xml:
```xml
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.calcite</groupId>
<artifactId>calcite-core</artifactId>
<version>1.27.0-SNAPSHOT</version>
<name>Calcite Core</name>
<description>Core Calcite APIs and engine</description>
<url>https://calcite.apache.org</url>
<inceptionYear>2012</inceptionYear>
<licenses>
<license>
<name>The Apache License, Version 2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
<comments>A business-friendly OSS license</comments>
</license>
</licenses>
<mailingLists>
<mailingList>
<name>Apache Calcite developers list</name>
<subscribe>dev-subscribe@calcite.apache.org</subscribe>
<unsubscribe>dev-unsubscribe@calcite.apache.org</unsubscribe>
<post>dev@calcite.apache.org</post>
<archive>https://lists.apache.org/list.html?dev@calcite.apache.org</archive>
</mailingList>
</mailingLists>
<scm>
<connection>scm:git:https://gitbox.apache.org/repos/asf/calcite.git</connection>
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/calcite.git</developerConnection>
<url>https://github.com/apache/calcite</url>
</scm>
<issueManagement>
<system>Jira</system>
<url>https://issues.apache.org/jira/browse/CALCITE</url>
</issueManagement>
<dependencies>
<dependency>
<groupId>org.apache.calcite</groupId>
<artifactId>calcite-linq4j</artifactId>
<version>1.27.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>com.esri.geometry</groupId>
<artifactId>esri-geometry-api</artifactId>
<version>2.2.0</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>2.10.0</version>
</dependency>
<dependency>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_annotations</artifactId>
<version>2.5.1</version>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>29.0-jre</version>
</dependency>
<dependency>
<groupId>org.apache.calcite.avatica</groupId>
<artifactId>avatica-core</artifactId>
<version>1.17.0</version>
</dependency>
<dependency>
<groupId>org.apiguardian</groupId>
<artifactId>apiguardian-api</artifactId>
<version>1.1.0</version>
</dependency>
<dependency>
<groupId>org.checkerframework</groupId>
<artifactId>checker-qual</artifactId>
<version>3.10.0</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>1.7.25</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.10.0</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.10.0</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-yaml</artifactId>
<version>2.10.0</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.google.uzaygezen</groupId>
<artifactId>uzaygezen-core</artifactId>
<version>0.2</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.jayway.jsonpath</groupId>
<artifactId>json-path</artifactId>
<version>2.4.0</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.yahoo.datasketches</groupId>
<artifactId>sketches-core</artifactId>
<version>0.9.0</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
<version>1.12</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>net.hydromatic</groupId>
<artifactId>aggdesigner-algorithm</artifactId>
<version>6.0</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-dbcp2</artifactId>
<version>2.6.0</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.8</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>2.4</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.codehaus.janino</groupId>
<artifactId>commons-compiler</artifactId>
<version>3.0.11</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.codehaus.janino</groupId>
<artifactId>janino</artifactId>
<version>3.0.11</version>
<scope>runtime</scope>
</dependency>
</dependencies>
</project>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] vlsi merged pull request #2362: Update dependency declarations: adjust api vs implementation, remove unused ones
Posted by GitBox <gi...@apache.org>.
vlsi merged pull request #2362:
URL: https://github.com/apache/calcite/pull/2362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] vlsi commented on pull request #2362: Update dependency declarations: adjust api vs implementation, remove unused ones
Posted by GitBox <gi...@apache.org>.
vlsi commented on pull request #2362:
URL: https://github.com/apache/calcite/pull/2362#issuecomment-790119499
The dependency analysis plugin still produces warnings, however, I believe those are false positives. I would follow up on them with the plugin maintainer.
```
./gradlew buildHealth --no-parallel --no-daemon
Execution failed for task ':buildHealth'.
> Advice for root project
Looking good! No changes needed
Advice for project :babel
Looking good! No changes needed
Advice for project :bom
Looking good! No changes needed
Advice for project :cassandra
Looking good! No changes needed
Advice for project :core
Existing dependencies which should be modified to be as indicated:
- testImplementation("org.apache.commons:commons-dbcp2:2.6.0") (was implementation)
Plugin advice:
- java-library: this project has both java-library and org.jetbrains.kotlin.jvm applied, which is redundant. You can remove java-library
Advice for project :druid
Existing dependencies which should be modified to be as indicated:
- implementation("org.checkerframework:checker-qual:3.10.0") (was api)
Advice for project :elasticsearch
Existing dependencies which should be modified to be as indicated:
- implementation("org.slf4j:slf4j-api:1.7.25") (was api)
- implementation("com.fasterxml.jackson.core:jackson-core:2.10.0") (was api)
Advice for project :example
Looking good! No changes needed
Advice for project :example:csv
Existing dependencies which should be modified to be as indicated:
- implementation("org.checkerframework:checker-qual:3.10.0") (was api)
Advice for project :example:function
Unused dependencies which should be removed:
- implementation("com.google.guava:guava:29.0-jre")
Existing dependencies which should be modified to be as indicated:
- implementation("org.checkerframework:checker-qual:3.10.0") (was api)
Advice for project :file
Existing dependencies which should be modified to be as indicated:
- implementation("org.checkerframework:checker-qual:3.10.0") (was api)
Advice for project :geode
Existing dependencies which should be modified to be as indicated:
- implementation("org.checkerframework:checker-qual:3.10.0") (was api)
Advice for project :innodb
Looking good! No changes needed
Advice for project :kafka
Existing dependencies which should be modified to be as indicated:
- implementation("org.checkerframework:checker-qual:3.10.0") (was api)
Advice for project :linq4j
Looking good! No changes needed
Advice for project :mongodb
Looking good! No changes needed
Advice for project :pig
Existing dependencies which should be modified to be as indicated:
- implementation(project(":linq4j")) (was api)
Advice for project :piglet
Looking good! No changes needed
Advice for project :plus
Existing dependencies which should be modified to be as indicated:
- implementation(project(":linq4j")) (was api)
- testImplementation("org.checkerframework:checker-qual:3.10.0") (was api)
- testImplementation("net.hydromatic:tpcds:0.4") (was implementation)
Advice for project :redis
Looking good! No changes needed
Advice for project :release
Looking good! No changes needed
Advice for project :server
Existing dependencies which should be modified to be as indicated:
- implementation(project(":linq4j")) (was api)
Advice for project :spark
Existing dependencies which should be modified to be as indicated:
- implementation("xerces:xercesImpl:2.9.1") (was runtimeOnly)
Advice for project :splunk
Looking good! No changes needed
Advice for project :ubenchmark
Looking good! No changes needed
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org