You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/24 16:02:03 UTC
[GitHub] [incubator-nuttx] v01d opened a new pull request #862: STM32l4 LPTIM additions
v01d opened a new pull request #862:
URL: https://github.com/apache/incubator-nuttx/pull/862
This PR exposes some functionality of LPTIM timers on STM32L4. i also ran nxstyle and did some fixes. I got some warnings about some lines I did not change which related to some comment alignment which I think was intentional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #862: STM32l4 LPTIM additions
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #862:
URL: https://github.com/apache/incubator-nuttx/pull/862#issuecomment-619137788
Thanks, didn't really know if I was going to break the expected styling just to shut nxstyle up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #862: STM32l4 LPTIM additions
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #862:
URL: https://github.com/apache/incubator-nuttx/pull/862#issuecomment-619124289
Here is the trick to fix nxstyle issue:
```
arch/arm/src/stm32l4/stm32l4_lptim.h:40:1: error: Missing blank line after comment
```
Add one blank line before line 40
```
arch/arm/src/stm32l4/hardware/stm32l4_lptim.h:109:45: error: Wrong column position or missing blank line before comment
arch/arm/src/stm32l4/hardware/stm32l4_lptim.h:110:45: warning: Wrong column position of comment right of code
```
Add one blank line before line 100
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org