You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/18 09:07:59 UTC
[GitHub] [hudi] yui2010 opened a new pull request #1748: [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
yui2010 opened a new pull request #1748:
URL: https://github.com/apache/hudi/pull/1748
…BasedKeyGenerator
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #1748: [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#discussion_r443176993
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/keygen/TimestampBasedKeyGenerator.java
##########
@@ -27,10 +27,10 @@
import org.apache.hudi.utilities.exception.HoodieDeltaStreamerException;
import org.apache.avro.generic.GenericRecord;
+import org.apache.commons.lang3.time.FastDateFormat;
Review comment:
We solved a ton of bundle conflicts for commons lang and no longer use it in the project. Please rework or without requiring it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-691043300
> @leesf we no longer use SimpleDateFormat in TimestampBasedKeyGenerator. So the issues linked with usage of SimpleDateFormat are also no longer there. Guess we can close this?
sure, @yui2010 please reopen if you have the issue again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-691043300
> @leesf we no longer use SimpleDateFormat in TimestampBasedKeyGenerator. So the issues linked with usage of SimpleDateFormat are also no longer there. Guess we can close this?
sure, @yui2010 please reopen if you have the issue again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-690966794
@leesf we no longer use SimpleDateFormat in TimestampBasedKeyGenerator. So the issues linked with usage of SimpleDateFormat are also no longer there. Guess we can close this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yui2010 commented on pull request #1748: [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
yui2010 commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-645891968
1. in TimestampBasedKeyGenerator#getKey method, generate a HoodieKey will create a new SimpleDateFormat Object,the dateformat object can be reused as Class variable
2. SimpleDateFormat is not thread safe,there is always potential thread safe problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-690966794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on pull request #1748: [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-646126924
@yui2010 Thanks for your contributing, would you please check the travis error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-691043300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-690966794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-691043300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf closed pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
leesf closed pull request #1748:
URL: https://github.com/apache/hudi/pull/1748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf closed pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
leesf closed pull request #1748:
URL: https://github.com/apache/hudi/pull/1748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf closed pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
leesf closed pull request #1748:
URL: https://github.com/apache/hudi/pull/1748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #1748: [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-646397724
@yui2010 checkstyle issue, you can setup your IDE with style files from here : https://hudi.apache.org/contributing#ide-setup
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org