[GitHub] [airflow] uranusjr commented on a change in pull request #15444: An initial rework of the "Concepts" documentation

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #15444:
URL: https://github.com/apache/airflow/pull/15444#discussion_r617171559



##########
File path: docs/apache-airflow/executor/index.rst
##########
@@ -18,34 +18,62 @@
 Executor
 ========
 
-Executors are the mechanism by which task instances get run.
+Executors are the mechanism by which :doc:`task instances </concepts/tasks>` get run. They have a common API and are "pluggable", meaning you can swap executors based on your installation needs.
 
-Airflow has support for various executors. Current used is determined by the ``executor`` option in the ``[core]``
-section of the configuration file. This option should contain the name executor e.g. ``KubernetesExecutor``
-if it is a core executor. If it is to load your own executor, then you should specify the
-full path to the module e.g. ``my_acme_company.executors.MyCustomExecutor``.
+Airflow can only have one executor configured at a time; this is set by the ``executor`` option in the ``[core]``
+section of :doc:`the configuration file <../howto/set-config>`.

Review comment:
       Should this use absolute path instead?

##########
File path: docs/spelling_wordlist.txt
##########
@@ -1178,6 +1182,7 @@ resourceVersion
 resultset
 resumable
 retransmits
+reuseable

Review comment:
       I think *reusable* is the more accepted spelling?

##########
File path: docs/spelling_wordlist.txt
##########
@@ -1356,6 +1361,7 @@ tooltip
 tooltips
 traceback
 tracebacks
+tradeoff

Review comment:
       Maybe *trade-off* would work out of the box?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org