[jira] [Commented] (SOLR-14073) Fix segment look ahead NPE in CollapsingQParserPlugin

["Joel Bernstein (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018150#comment-17018150 ] 

Joel Bernstein commented on SOLR-14073:
---------------------------------------

The initial patch seems to work but it's quite hard to reason about.

I'm going to try a different approach which is easier to reason about which is to prepopulate the contexts array rather then populating it as the segments are visited. This should eliminate the look-ahead NPE as well.

> Fix segment look ahead NPE in CollapsingQParserPlugin
> -----------------------------------------------------
>
>                 Key: SOLR-14073
>                 URL: https://issues.apache.org/jira/browse/SOLR-14073
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Joel Bernstein
>            Assignee: Joel Bernstein
>            Priority: Major
>         Attachments: SOLR-14073.patch
>
>
> The CollapsingQParserPlugin has a bug that if every segment is not visited during the collect it throws an NPE. This causes the CollapsingQParserPlugin to not work when used with any feature that short circuits the segments during the collect. This includes using the CollapsingQParserPlugin twice in the same query and the time limiting collector.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org