You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/10/29 09:23:28 UTC
[GitHub] [pulsar] codelipenghui opened a new pull request #5491: Fix message
deduplicate issue while using external sequence id with batch produce
codelipenghui opened a new pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491
Fixes #5476
### Motivation
Fix #5476
### Modifications
1. Add `lowest_sequence_id` and `highest_sequence_id` in MessageMetadata and CommandSend to indicate the `batch lowest_sequence_id` and `highest_sequence_id`.
2. Handle batch message deduplicate check in MessageDeduplication
3. Response the `highest_sequence_id` to client and add message deduplicate check in client
### Verifying this change
Added new unit tests to verify this change
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (yes)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services