You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "lxbme (via GitHub)" <gi...@apache.org> on 2026/07/21 08:51:49 UTC

[PR] fix: accessible names for header icon buttons, Monaco contrast, drawer Escape [apisix-dashboard]

lxbme opened a new pull request, #3442:
URL: https://github.com/apache/apisix-dashboard/pull/3442

   **Why submit this pull request?**
   
   - [x] Bugfix
   
   **What changes will this PR take into?**
   
   Part of #3417 (a11y section). Accessibility quick wins — the app had exactly one `aria-label` in all of `src/`:
   
   - the header's icon-only buttons — settings, language, and the mobile navigation burger — had no accessible name; screen readers announced them as a bare "button". Each gets an `aria-label` from new `a11y.*` i18n keys.
   - view-mode Monaco text was gray-5 on the gray-0 editor background, about 2:1 — unreadable on a primary read path. Bumped to gray-7 (~7:1, clears WCAG AA).
   - the Select Plugins drawer set `closeOnEscape={false}` despite holding no unsaved state; Escape now closes it like any other dialog.
   
   **Scope, disclosed honestly:** the plugin-card action buttons the issue also lists carry visible text (Add/View/Edit/Delete), so they already have an accessible name — adding an `aria-label` would double-label them. The deeper combobox/`role` semantics rework and the e2e a11y assertion suite the issue mentions are a separate, larger change left for follow-up.
   
   **Tests.** e2e `a11y.icon-buttons-and-escape.spec.ts` covers the accessible names and the drawer's Escape-to-close.
   
   Blast radius: full local e2e suite — 179 passed; the only failure is `stream_routes.show-disabled-error`, a documented environment item that cannot run outside the repo's own compose project. Unit tests, lint and build clean.
   
   **Related issues**
   
   Part of #3417 (please do not auto-close the tracking issue)
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve?
   - [x] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document? (no user-facing document covers these controls)
   - [x] Is this PR backward compatible?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: accessible names for header icon buttons, Monaco contrast, drawer Escape [apisix-dashboard]

Posted by "LiteSun (via GitHub)" <gi...@apache.org>.
LiteSun commented on PR #3442:
URL: https://github.com/apache/apisix-dashboard/pull/3442#issuecomment-5043705671

   Reviewed the accessibility changes and regression coverage. I did not find any blocking issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: accessible names for header icon buttons, Monaco contrast, drawer Escape [apisix-dashboard]

Posted by "guoqqqi (via GitHub)" <gi...@apache.org>.
guoqqqi merged PR #3442:
URL: https://github.com/apache/apisix-dashboard/pull/3442


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org