You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/19 08:09:15 UTC
[GitHub] [cloudstack-primate] shwstppr opened a new pull request #436: feature: template ovf properties
shwstppr opened a new pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#discussion_r443329290
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -761,6 +825,9 @@ export default {
}
},
methods: {
+ removeQuotes (value) {
Review comment:
JSON.stringify() (javascript pojo)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-655348920
Update - discussed with @DaanHoogland I'll review the backend PR and I'll make further changes in this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-656040657
Tested with backend, will do a final test by tomorrow and merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-652279174
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd removed a comment on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-655316179
With @Pearl1594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#discussion_r443329598
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -1209,6 +1284,34 @@ export default {
this.loading.isos = false
})
},
+ fetchTemplateOvfProperties (templateId) {
+ this.loading.templateOvfProperties = true
+ const params = {
+ id: templateId
+ }
+ api('listTemplateOvfProperties', params).then(json => {
Review comment:
Note - upstream PR/feature may get rid of this API; and instead return the properties as part of the listTemplates API response cc @DaanHoogland
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-647949992
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/436 (JID-2092)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-649493187
cc @DaanHoogland Abhishek is done with the UI component, based on any changes in the API/response we may need to refactor this again (should be quicker now that we've the groundwork complete)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-652278506
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-654093019
Please merge latest master and fix any conflicts? Thanks.
@davidjumani please take over and discuss with @DaanHoogland for any changes in the API/response done in backend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd removed a comment on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-654664794
With @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-652287866
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/436 (JID-2173)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-654664794
With @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-647941721
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-655316179
With @Pearl1594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-647941656
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #436: feature: template ovf properties
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #436:
URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-647855169
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org