You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "fundaev (via GitHub)" <gi...@apache.org> on 2023/07/11 12:18:31 UTC
[GitHub] [pulsar-client-cpp] fundaev opened a new pull request, #301: [fix][client] Memory leak during GET_LAST_MESSAGE_ID command processing.
fundaev opened a new pull request, #301:
URL: https://github.com/apache/pulsar-client-cpp/pull/301
### Motivation
`ClientConnection::newGetLastMessageId` method uses `ClientConnection::sendRequestWithId` one to send request. It adds a new node into `ClientConnection::pendingRequests_` map. However `ClientConnection::handleGetLastMessageIdResponse` method does not affect this map. As a result the size of mentioned map is increased every time when `Reader::getLastMessageIdAsync` method is called.
### Modifications
`ClientConnection::newGetLastMessageId` method use now `ClientConnection::sendCommand` one to send request.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as ConsumerTest.testGetLastMessageId and ConsumerTest.testGetLastMessageIdBlockWhenConnectionDisconnected.
### Documentation
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [x] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #301: [fix][client] Memory leak during GET_LAST_MESSAGE_ID command processing.
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #301:
URL: https://github.com/apache/pulsar-client-cpp/pull/301#issuecomment-1647916741
> Should I do anything else after your commit?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #301: [fix][client] Memory leak during GET_LAST_MESSAGE_ID command processing.
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on code in PR #301:
URL: https://github.com/apache/pulsar-client-cpp/pull/301#discussion_r1271664579
##########
lib/GetLastMessageIdResponse.h:
##########
@@ -20,11 +20,16 @@
#include <pulsar/MessageId.h>
#include <pulsar/Result.h>
+#include "Future.h"
#include <iostream>
Review Comment:
```suggestion
#include <iostream>
#include "Future.h"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #301: [fix][client] Memory leak during GET_LAST_MESSAGE_ID command processing.
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower merged PR #301:
URL: https://github.com/apache/pulsar-client-cpp/pull/301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] fundaev commented on pull request #301: [fix][client] Memory leak during GET_LAST_MESSAGE_ID command processing.
Posted by "fundaev (via GitHub)" <gi...@apache.org>.
fundaev commented on PR #301:
URL: https://github.com/apache/pulsar-client-cpp/pull/301#issuecomment-1646041058
Sorry for late response.
Please look at the solution now. I left `pendingGetLastMessageIdRequests_` cache. Otherwise it's necessary to return `Future<Result, ResponseData>` in `ClientConnection::newGetLastMessageId`. But the problem with timeout is fixed now too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] fundaev commented on pull request #301: [fix][client] Memory leak during GET_LAST_MESSAGE_ID command processing.
Posted by "fundaev (via GitHub)" <gi...@apache.org>.
fundaev commented on PR #301:
URL: https://github.com/apache/pulsar-client-cpp/pull/301#issuecomment-1647431481
Should I do anything else after your commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #301: [fix][client] Memory leak during GET_LAST_MESSAGE_ID command processing.
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #301:
URL: https://github.com/apache/pulsar-client-cpp/pull/301#issuecomment-1637447932
Could you address my comment? I will wait for some time. If not, I might open another PR to fix it since I'm going to cut the 3.2.0 release soon (maybe the next week)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] Radrik5 commented on pull request #301: [fix][client] Memory leak during GET_LAST_MESSAGE_ID command processing.
Posted by "Radrik5 (via GitHub)" <gi...@apache.org>.
Radrik5 commented on PR #301:
URL: https://github.com/apache/pulsar-client-cpp/pull/301#issuecomment-1631196548
This change partially reverts commit https://github.com/apache/pulsar-client-cpp/commit/87351037b72574c1b59379bacc4e7a3d78682521 probably re-injecting timeout issue it fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] fundaev commented on pull request #301: [fix][client] Memory leak during GET_LAST_MESSAGE_ID command processing.
Posted by "fundaev (via GitHub)" <gi...@apache.org>.
fundaev commented on PR #301:
URL: https://github.com/apache/pulsar-client-cpp/pull/301#issuecomment-1637495139
Yes, I'll correct the solution soon. Sorry for the delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org