[jira] [Commented] (RANGER-5211) Logic to check if metric collection is thread-safe or not should not parse entire conf everytime

["Vikas Kumar (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RANGER-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951619#comment-17951619 ] 

Vikas Kumar commented on RANGER-5211:
-------------------------------------

PR: [https://github.com/apache/ranger/pull/575]

commit: 8b1d10863488425c7bf87540deb875413a5ff68c

PR has been validated, reviewed and merged.

> Logic to check if metric collection is thread-safe or not should not parse entire conf everytime
> ------------------------------------------------------------------------------------------------
>
>                 Key: RANGER-5211
>                 URL: https://issues.apache.org/jira/browse/RANGER-5211
>             Project: Ranger
>          Issue Type: Improvement
>          Components: kms
>            Reporter: Vikas Kumar
>            Assignee: Vikas Kumar
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> KMSWebApp.isMetricCollectionThreadSafe() should not try to get KMS configuration every time and then check if it is enabled or not. 
>  
> Configuration constructor acquires lock on the underlying kmsConf object and hence other threads will have to wait.
> Instead, it should initialise an instance member once and should reuse the same. It would be more efficient from performance point of view.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)