You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/09/21 11:37:03 UTC
[GitHub] [netbeans] JaroslavTulach opened a new pull request #2386: Cleanup of not just dependencies
JaroslavTulach opened a new pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386
While working on [java.lsp.server debugging](https://github.com/JaroslavTulach/netbeans/tree/java-lsp-server-debugging-attempt2) various issues with module dependencies, their ability to run in headless mode, to run without `core.windows` module, etc. have been identified. This PR is my attempt to bring them into NetBeans master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491978666
##########
File path: ide/projectapi/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi/1
-OpenIDE-Module-Specification-Version: 1.77
+OpenIDE-Module-Specification-Version: 1.78
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/Bundle.properties
OpenIDE-Module-Layer: org/netbeans/modules/projectapi/layer.xml
-OpenIDE-Module-Recommends: cnb.org.netbeans.modules.projectapi.nb
+OpenIDE-Module-Needs: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
@tzezula: Here we need an implementation of `org.netbeans.spi.project.ProjectManagerImplementation`. Previously the module recommended single implementation, but that wasn't enough. If the module was missing a `NullPointerException` was raised. Hence we "need" - e.g. the module isn't going to be enabled without an implementation, but the implementation can come from any module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r493159952
##########
File path: ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
##########
@@ -441,12 +441,18 @@ boolean closeBeforeOpen(final Project[] arr) {
}
});
}
-
+
+ @NbBundle.Messages({
+ "LOAD_PROJECTS_ON_START=true"
+ })
private void loadOnBackground() {
- lazilyOpenedProjects = new ArrayList<Project>();
- List<URL> URLs = OpenProjectListSettings.getInstance().getOpenProjectsURLs();
- final List<Project> initial = new ArrayList<Project>();
- final LinkedList<Project> projects = URLs2Projects(URLs);
+ lazilyOpenedProjects = new ArrayList<>();
+ final boolean loadProjectsOnStart = "true".equals(Bundle.LOAD_PROJECTS_ON_START());
Review comment:
Yes, it is used at many places, controlling behavior of splash screen, controlling behavior of window system. We even have `<api group='branding'..../>` for that case - here is the current [list of branding APIs](https://bits.netbeans.org/dev/javadoc/branding.html).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491975900
##########
File path: platform/settings/src/org/netbeans/modules/settings/RecognizeInstanceObjects.java
##########
@@ -93,24 +94,49 @@ protected Lookup lookupFor(Object obj) {
return null;
}
- private static final class OverObjects extends ProxyLookup
- implements PropertyChangeListener, FileChangeListener {
- private final String path;
-
- public OverObjects(String path) {
- super(delegates(null, path));
- this.path = path;
+ private static final class MSL implements PropertyChangeListener {
+ private final PropertyChangeSupport pcs = new PropertyChangeSupport(this);
+ public static final MSL DEFAULT = new MSL();
+ static {
try {
ModuleSystem ms = Main.getModuleSystem(false);
if (ms != null) {
ModuleManager man = ms.getManager();
- man.addPropertyChangeListener(WeakListeners.propertyChange(this, man));
+ man.addPropertyChangeListener(WeakListeners.propertyChange(DEFAULT, man));
} else {
LOG.log(Level.WARNING, "Not listening on module system");
Review comment:
This message was printed out everytime new instance of `OverObjects` was created in a unit test. Quite annoying. Enough to emit the warning once per test.
##########
File path: ide/projectapi.nb/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi.nb
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/nb/Bundle.properties
-OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb
-OpenIDE-Module-Specification-Version: 1.13
+OpenIDE-Module-Provides: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
@tzezula, there is no need to `OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb` it is provided automatically. Rather than that the module now provides implementation of `org.netbeans.spi.project.ProjectManagerImplementation`.
##########
File path: ide/projectapi.nb/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi.nb
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/nb/Bundle.properties
-OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb
-OpenIDE-Module-Specification-Version: 1.13
+OpenIDE-Module-Provides: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
@tzezula, there is no need to `OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb` it is provided automatically. Rather than that the module now provides token `org.netbeans.spi.project.ProjectManagerImplementation` to stress the fact that it provides implementation of that service.
##########
File path: extide/gradle/src/org/netbeans/modules/gradle/api/execute/RunUtils.java
##########
@@ -100,6 +100,9 @@ public static FileObject extractFileObjectfromLookup(Lookup lookup) {
SingleMethod method = methods.iterator().next();
files.add(method.getFile());
}
+ if (files.isEmpty()) {
+ files.addAll(lookup.lookupAll(FileObject.class));
+ }
Review comment:
This is the same [fix as in Maven](78fbf67)
##########
File path: java/maven/src/org/netbeans/modules/maven/spi/actions/AbstractMavenActionsProvider.java
##########
@@ -88,6 +88,10 @@ public AbstractMavenActionsProvider() {
files.add(method.getFile());
}
+ if (files.isEmpty()) {
Review comment:
Also [fixed in Gradle](034a600c1329).
##########
File path: ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
##########
@@ -441,12 +441,18 @@ boolean closeBeforeOpen(final Project[] arr) {
}
});
}
-
+
+ @NbBundle.Messages({
+ "LOAD_PROJECTS_ON_START=true"
+ })
private void loadOnBackground() {
- lazilyOpenedProjects = new ArrayList<Project>();
- List<URL> URLs = OpenProjectListSettings.getInstance().getOpenProjectsURLs();
- final List<Project> initial = new ArrayList<Project>();
- final LinkedList<Project> projects = URLs2Projects(URLs);
+ lazilyOpenedProjects = new ArrayList<>();
+ final boolean loadProjectsOnStart = "true".equals(Bundle.LOAD_PROJECTS_ON_START());
Review comment:
Yes, it is used at many places, controlling behavior of splash screen, controlling behavior of window system. We even have `<api group='branding'..../>` for that case - here is the current [list of branding APIs](https://bits.netbeans.org/dev/javadoc/branding.html).
##########
File path: ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
##########
@@ -441,12 +441,18 @@ boolean closeBeforeOpen(final Project[] arr) {
}
});
}
-
+
+ @NbBundle.Messages({
+ "LOAD_PROJECTS_ON_START=true"
+ })
private void loadOnBackground() {
- lazilyOpenedProjects = new ArrayList<Project>();
- List<URL> URLs = OpenProjectListSettings.getInstance().getOpenProjectsURLs();
- final List<Project> initial = new ArrayList<Project>();
- final LinkedList<Project> projects = URLs2Projects(URLs);
+ lazilyOpenedProjects = new ArrayList<>();
+ final boolean loadProjectsOnStart = "true".equals(Bundle.LOAD_PROJECTS_ON_START());
Review comment:
Yes, it is used at many places, controlling behavior of splash screen, controlling behavior of window system. We even have `<api group='branding'..../>` for that case - here is the current [list of branding APIs](https://bits.netbeans.org/dev/javadoc/branding.html).
Using branding API is useful if the change in behavior is made per NetBeans application - e.g. different behavior for NetBeans IDE, different for JDeveloper, different for VSCode, etc.
##########
File path: ide/parsing.indexing/manifest.mf
##########
@@ -4,4 +4,5 @@ OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/parsing/indexing/Bundle.p
OpenIDE-Module-Layer: org/netbeans/modules/parsing/impl/indexing/layer.xml
AutoUpdate-Show-In-Client: false
OpenIDE-Module-Implementation-Version: 1
+OpenIDE-Module-Needs: org.netbeans.modules.parsing.impl.indexing.implspi.ActiveDocumentProvider
Review comment:
I tried to assemble minimal application and I was getting `IllegalStateException`. Turned out that `parsing.indexing` cannot run without `ActiveDocumentProvider`. The `OpenIDE-Module-Needs` just formalizes that dependency. @tzezula may confirm, but the code in `RepositoryUpdater` speaks clearly:
```java
this.activeDocProvider = Lookup.getDefault().lookup(ActiveDocumentProvider.class);
if (this.activeDocProvider == null) {
throw new IllegalStateException("No ActiveDocumentProvider instance in global lookup."); //NOI18N
}
```
##########
File path: ide/javascript2.debug/nbproject/project.xml
##########
@@ -114,6 +114,7 @@
<friend-packages>
<friend>org.netbeans.modules.debugger.jpda.js</friend>
<friend>org.netbeans.modules.debugger.jpda.truffle</friend>
+ <friend>org.netbeans.modules.java.lsp.server</friend>
Review comment:
Good catch. This is a change needed for the [java.lsp.server debugging](https://github.com/JaroslavTulach/netbeans/tree/java-lsp-server-debugging-attempt2), but not really a cleanup. Moreover one should bump module version when changing list of friends.
Let's remove the change from this PR: 2847f6e
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491976427
##########
File path: java/maven/src/org/netbeans/modules/maven/spi/actions/AbstractMavenActionsProvider.java
##########
@@ -88,6 +88,10 @@ public AbstractMavenActionsProvider() {
files.add(method.getFile());
}
+ if (files.isEmpty()) {
Review comment:
Ant projects honor `FileObject` as a selection in the `Lookup`, but Maven projects didn't. After this change they will use `FileObject` (if no `DataObject` is found) as the indentification of main file to execute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tzezula commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
tzezula commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r492891025
##########
File path: ide/projectapi/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi/1
-OpenIDE-Module-Specification-Version: 1.77
+OpenIDE-Module-Specification-Version: 1.78
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/Bundle.properties
OpenIDE-Module-Layer: org/netbeans/modules/projectapi/layer.xml
-OpenIDE-Module-Recommends: cnb.org.netbeans.modules.projectapi.nb
+OpenIDE-Module-Needs: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
Makes sense.
##########
File path: ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
##########
@@ -441,12 +441,18 @@ boolean closeBeforeOpen(final Project[] arr) {
}
});
}
-
+
+ @NbBundle.Messages({
+ "LOAD_PROJECTS_ON_START=true"
+ })
private void loadOnBackground() {
- lazilyOpenedProjects = new ArrayList<Project>();
- List<URL> URLs = OpenProjectListSettings.getInstance().getOpenProjectsURLs();
- final List<Project> initial = new ArrayList<Project>();
- final LinkedList<Project> projects = URLs2Projects(URLs);
+ lazilyOpenedProjects = new ArrayList<>();
+ final boolean loadProjectsOnStart = "true".equals(Bundle.LOAD_PROJECTS_ON_START());
Review comment:
It's an interesting usage of resource bundle. :-)
But I think it's rather a hack to use module resource bundle for configuration.
Do we already use such a pattern somewhere?
If not I would prefer a method.
##########
File path: ide/projectapi.nb/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi.nb
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/nb/Bundle.properties
-OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb
-OpenIDE-Module-Specification-Version: 1.13
+OpenIDE-Module-Provides: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r492922729
##########
File path: ide/parsing.indexing/manifest.mf
##########
@@ -4,4 +4,5 @@ OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/parsing/indexing/Bundle.p
OpenIDE-Module-Layer: org/netbeans/modules/parsing/impl/indexing/layer.xml
AutoUpdate-Show-In-Client: false
OpenIDE-Module-Implementation-Version: 1
+OpenIDE-Module-Needs: org.netbeans.modules.parsing.impl.indexing.implspi.ActiveDocumentProvider
Review comment:
Just to understand this correctly: Is the intention here, that parsing.indexing and parsing.nb are loosely coupled? I.e. parsing.indexing needs and implemenation of that SPI?
##########
File path: ide/javascript2.debug/nbproject/project.xml
##########
@@ -114,6 +114,7 @@
<friend-packages>
<friend>org.netbeans.modules.debugger.jpda.js</friend>
<friend>org.netbeans.modules.debugger.jpda.truffle</friend>
+ <friend>org.netbeans.modules.java.lsp.server</friend>
Review comment:
I don't see the reason for this change - am I missing the dependency relationship?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491975367
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/AutoUpdateCatalogParser.java
##########
@@ -240,6 +241,8 @@ public void endElement (String uri, String localName, String qName) throws SAXEx
break;
case manifest :
break;
+ case message_digest:
Review comment:
The `AutoUpdate` task was very verbose with modern catalogs. Assuming this field got in with one of @matthiasblaesing fixes, I've added it to the set of recognized, but not processed fields.
##########
File path: platform/settings/src/org/netbeans/modules/settings/RecognizeInstanceObjects.java
##########
@@ -93,24 +94,49 @@ protected Lookup lookupFor(Object obj) {
return null;
}
- private static final class OverObjects extends ProxyLookup
- implements PropertyChangeListener, FileChangeListener {
- private final String path;
-
- public OverObjects(String path) {
- super(delegates(null, path));
- this.path = path;
+ private static final class MSL implements PropertyChangeListener {
+ private final PropertyChangeSupport pcs = new PropertyChangeSupport(this);
+ public static final MSL DEFAULT = new MSL();
+ static {
try {
ModuleSystem ms = Main.getModuleSystem(false);
if (ms != null) {
ModuleManager man = ms.getManager();
- man.addPropertyChangeListener(WeakListeners.propertyChange(this, man));
+ man.addPropertyChangeListener(WeakListeners.propertyChange(DEFAULT, man));
} else {
LOG.log(Level.WARNING, "Not listening on module system");
Review comment:
This message was printed out everytime new instance of `OverObjects` was created in a unit test. Quite annoying. Enough to warning once per test.
##########
File path: java/maven/src/org/netbeans/modules/maven/spi/actions/AbstractMavenActionsProvider.java
##########
@@ -88,6 +88,10 @@ public AbstractMavenActionsProvider() {
files.add(method.getFile());
}
+ if (files.isEmpty()) {
Review comment:
Ant projects honor `FileObject` as a selection in the `Lookup`, but Maven projects didn't. After this change they will use `FileObject` (if no `DataObject` is found) as the indentification of main file to execute.
##########
File path: ide/projectapi.nb/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi.nb
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/nb/Bundle.properties
-OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb
-OpenIDE-Module-Specification-Version: 1.13
+OpenIDE-Module-Provides: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
@tzezula, there is no need to `OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb` it is provided automatically. Rather than that the module no provides implementation of `org.netbeans.spi.project.ProjectManagerImplementation`.
##########
File path: ide/projectapi/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi/1
-OpenIDE-Module-Specification-Version: 1.77
+OpenIDE-Module-Specification-Version: 1.78
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/Bundle.properties
OpenIDE-Module-Layer: org/netbeans/modules/projectapi/layer.xml
-OpenIDE-Module-Recommends: cnb.org.netbeans.modules.projectapi.nb
+OpenIDE-Module-Needs: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
@tzezula: Here we need an implementation of `org.netbeans.spi.project.ProjectManagerImplementation`. Previously the module recommended single implementation, but that wasn't enough. If the module was missing a `NullPointerException` was raised. Hence we "need" - e.g. the module isn't going to be enabled without an implementation, but the implementation can come from any module.
##########
File path: ide/web.browser.api/manifest.mf
##########
@@ -2,5 +2,5 @@ Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.web.browser.api
OpenIDE-Module-Layer: org/netbeans/modules/web/browser/ui/resources/layer.xml
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/web/browser/api/Bundle.properties
-OpenIDE-Module-Requires: org.openide.windows.WindowManager
+OpenIDE-Module-Recommends: org.openide.windows.WindowManager
Review comment:
This module can run without window manager. Hence just "recommends".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r493164127
##########
File path: ide/javascript2.debug/nbproject/project.xml
##########
@@ -114,6 +114,7 @@
<friend-packages>
<friend>org.netbeans.modules.debugger.jpda.js</friend>
<friend>org.netbeans.modules.debugger.jpda.truffle</friend>
+ <friend>org.netbeans.modules.java.lsp.server</friend>
Review comment:
Good catch. This is a change needed for the [java.lsp.server debugging](https://github.com/JaroslavTulach/netbeans/tree/java-lsp-server-debugging-attempt2), but not really a cleanup. Moreover one should bump module version when changing list of friends.
Let's remove the change from this PR: 2847f6e
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#issuecomment-696862713
Travis is failing to access Apache's gitbox, restarted the failing jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r492922729
##########
File path: ide/parsing.indexing/manifest.mf
##########
@@ -4,4 +4,5 @@ OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/parsing/indexing/Bundle.p
OpenIDE-Module-Layer: org/netbeans/modules/parsing/impl/indexing/layer.xml
AutoUpdate-Show-In-Client: false
OpenIDE-Module-Implementation-Version: 1
+OpenIDE-Module-Needs: org.netbeans.modules.parsing.impl.indexing.implspi.ActiveDocumentProvider
Review comment:
Just to understand this correctly: Is the intention here, that parsing.indexing and parsing.nb are loosely coupled? I.e. parsing.indexing needs and implemenation of that SPI?
##########
File path: ide/javascript2.debug/nbproject/project.xml
##########
@@ -114,6 +114,7 @@
<friend-packages>
<friend>org.netbeans.modules.debugger.jpda.js</friend>
<friend>org.netbeans.modules.debugger.jpda.truffle</friend>
+ <friend>org.netbeans.modules.java.lsp.server</friend>
Review comment:
I don't see the reason for this change - am I missing the dependency relationship?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] asfgit merged pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491975900
##########
File path: platform/settings/src/org/netbeans/modules/settings/RecognizeInstanceObjects.java
##########
@@ -93,24 +94,49 @@ protected Lookup lookupFor(Object obj) {
return null;
}
- private static final class OverObjects extends ProxyLookup
- implements PropertyChangeListener, FileChangeListener {
- private final String path;
-
- public OverObjects(String path) {
- super(delegates(null, path));
- this.path = path;
+ private static final class MSL implements PropertyChangeListener {
+ private final PropertyChangeSupport pcs = new PropertyChangeSupport(this);
+ public static final MSL DEFAULT = new MSL();
+ static {
try {
ModuleSystem ms = Main.getModuleSystem(false);
if (ms != null) {
ModuleManager man = ms.getManager();
- man.addPropertyChangeListener(WeakListeners.propertyChange(this, man));
+ man.addPropertyChangeListener(WeakListeners.propertyChange(DEFAULT, man));
} else {
LOG.log(Level.WARNING, "Not listening on module system");
Review comment:
This message was printed out everytime new instance of `OverObjects` was created in a unit test. Quite annoying. Enough to emit the warning once per test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tzezula commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
tzezula commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r492891025
##########
File path: ide/projectapi/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi/1
-OpenIDE-Module-Specification-Version: 1.77
+OpenIDE-Module-Specification-Version: 1.78
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/Bundle.properties
OpenIDE-Module-Layer: org/netbeans/modules/projectapi/layer.xml
-OpenIDE-Module-Recommends: cnb.org.netbeans.modules.projectapi.nb
+OpenIDE-Module-Needs: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
Makes sense.
##########
File path: ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
##########
@@ -441,12 +441,18 @@ boolean closeBeforeOpen(final Project[] arr) {
}
});
}
-
+
+ @NbBundle.Messages({
+ "LOAD_PROJECTS_ON_START=true"
+ })
private void loadOnBackground() {
- lazilyOpenedProjects = new ArrayList<Project>();
- List<URL> URLs = OpenProjectListSettings.getInstance().getOpenProjectsURLs();
- final List<Project> initial = new ArrayList<Project>();
- final LinkedList<Project> projects = URLs2Projects(URLs);
+ lazilyOpenedProjects = new ArrayList<>();
+ final boolean loadProjectsOnStart = "true".equals(Bundle.LOAD_PROJECTS_ON_START());
Review comment:
It's an interesting usage of resource bundle. :-)
But I think it's rather a hack to use module resource bundle for configuration.
Do we already use such a pattern somewhere?
If not I would prefer a method.
##########
File path: ide/projectapi.nb/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi.nb
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/nb/Bundle.properties
-OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb
-OpenIDE-Module-Specification-Version: 1.13
+OpenIDE-Module-Provides: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491979072
##########
File path: ide/web.browser.api/manifest.mf
##########
@@ -2,5 +2,5 @@ Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.web.browser.api
OpenIDE-Module-Layer: org/netbeans/modules/web/browser/ui/resources/layer.xml
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/web/browser/api/Bundle.properties
-OpenIDE-Module-Requires: org.openide.windows.WindowManager
+OpenIDE-Module-Recommends: org.openide.windows.WindowManager
Review comment:
This module can run without window manager. Hence just "recommends".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491977373
##########
File path: ide/projectapi.nb/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi.nb
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/nb/Bundle.properties
-OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb
-OpenIDE-Module-Specification-Version: 1.13
+OpenIDE-Module-Provides: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
@tzezula, there is no need to `OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb` it is provided automatically. Rather than that the module now provides implementation of `org.netbeans.spi.project.ProjectManagerImplementation`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#issuecomment-697099157
> Overall seems good to me. Just please re-evaluate the usage of projectui resource bundle for configuration.
There are [Branding APIs](https://bits.netbeans.org/dev/javadoc/branding.html) in the NetBeans code base. It is a better than `System.getProperty` way to configure the system (no need to mangle with command line switches), if the configuration is "per application" (which comes with own branding). It is more lightweight than [API seam](http://wiki.apidesign.org/wiki/APISeam).
> looks sane to me. I left two inline questions, but these are just to improve my understanding.
Answered and fixed in 2847f6e.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#issuecomment-697099157
> Overall seems good to me. Just please re-evaluate the usage of projectui resource bundle for configuration.
There are [Branding APIs](https://bits.netbeans.org/dev/javadoc/branding.html) in the NetBeans code base. It is a better than `System.getProperty` way to configure the system (no need to mangle with command line switches), if the configuration is "per application" (which comes with own branding). It is more lightweight than [API seam](http://wiki.apidesign.org/wiki/APISeam).
> looks sane to me. I left two inline questions, but these are just to improve my understanding.
Answered and fixed in 2847f6e.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#issuecomment-696862713
Travis is failing to access Apache's gitbox, restarted the failing jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r493159952
##########
File path: ide/projectui/src/org/netbeans/modules/project/ui/OpenProjectList.java
##########
@@ -441,12 +441,18 @@ boolean closeBeforeOpen(final Project[] arr) {
}
});
}
-
+
+ @NbBundle.Messages({
+ "LOAD_PROJECTS_ON_START=true"
+ })
private void loadOnBackground() {
- lazilyOpenedProjects = new ArrayList<Project>();
- List<URL> URLs = OpenProjectListSettings.getInstance().getOpenProjectsURLs();
- final List<Project> initial = new ArrayList<Project>();
- final LinkedList<Project> projects = URLs2Projects(URLs);
+ lazilyOpenedProjects = new ArrayList<>();
+ final boolean loadProjectsOnStart = "true".equals(Bundle.LOAD_PROJECTS_ON_START());
Review comment:
Yes, it is used at many places, controlling behavior of splash screen, controlling behavior of window system. We even have `<api group='branding'..../>` for that case - here is the current [list of branding APIs](https://bits.netbeans.org/dev/javadoc/branding.html).
Using branding API is useful if the change in behavior is made per NetBeans application - e.g. different behavior for NetBeans IDE, different for JDeveloper, different for VSCode, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491977373
##########
File path: ide/projectapi.nb/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi.nb
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/nb/Bundle.properties
-OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb
-OpenIDE-Module-Specification-Version: 1.13
+OpenIDE-Module-Provides: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
@tzezula, there is no need to `OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb` it is provided automatically. Rather than that the module now provides token `org.netbeans.spi.project.ProjectManagerImplementation` to stress the fact that it provides implementation of that service.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491975900
##########
File path: platform/settings/src/org/netbeans/modules/settings/RecognizeInstanceObjects.java
##########
@@ -93,24 +94,49 @@ protected Lookup lookupFor(Object obj) {
return null;
}
- private static final class OverObjects extends ProxyLookup
- implements PropertyChangeListener, FileChangeListener {
- private final String path;
-
- public OverObjects(String path) {
- super(delegates(null, path));
- this.path = path;
+ private static final class MSL implements PropertyChangeListener {
+ private final PropertyChangeSupport pcs = new PropertyChangeSupport(this);
+ public static final MSL DEFAULT = new MSL();
+ static {
try {
ModuleSystem ms = Main.getModuleSystem(false);
if (ms != null) {
ModuleManager man = ms.getManager();
- man.addPropertyChangeListener(WeakListeners.propertyChange(this, man));
+ man.addPropertyChangeListener(WeakListeners.propertyChange(DEFAULT, man));
} else {
LOG.log(Level.WARNING, "Not listening on module system");
Review comment:
This message was printed out everytime new instance of `OverObjects` was created in a unit test. Quite annoying. Enough to warning once per test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491975367
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/AutoUpdateCatalogParser.java
##########
@@ -240,6 +241,8 @@ public void endElement (String uri, String localName, String qName) throws SAXEx
break;
case manifest :
break;
+ case message_digest:
Review comment:
The `AutoUpdate` task was very verbose with modern catalogs. Assuming this field got in with one of @matthiasblaesing fixes, I've added it to the set of recognized, but not processed fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r492566172
##########
File path: java/maven/src/org/netbeans/modules/maven/spi/actions/AbstractMavenActionsProvider.java
##########
@@ -88,6 +88,10 @@ public AbstractMavenActionsProvider() {
files.add(method.getFile());
}
+ if (files.isEmpty()) {
Review comment:
Also [fixed in Gradle](034a600c1329).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r493162511
##########
File path: ide/parsing.indexing/manifest.mf
##########
@@ -4,4 +4,5 @@ OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/parsing/indexing/Bundle.p
OpenIDE-Module-Layer: org/netbeans/modules/parsing/impl/indexing/layer.xml
AutoUpdate-Show-In-Client: false
OpenIDE-Module-Implementation-Version: 1
+OpenIDE-Module-Needs: org.netbeans.modules.parsing.impl.indexing.implspi.ActiveDocumentProvider
Review comment:
I tried to assemble minimal application and I was getting `IllegalStateException`. Turned out that `parsing.indexing` cannot run without `ActiveDocumentProvider`. The `OpenIDE-Module-Needs` just formalizes that dependency. @tzezula may confirm, but the code in `RepositoryUpdater` speaks clearly:
```java
this.activeDocProvider = Lookup.getDefault().lookup(ActiveDocumentProvider.class);
if (this.activeDocProvider == null) {
throw new IllegalStateException("No ActiveDocumentProvider instance in global lookup."); //NOI18N
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r492565803
##########
File path: extide/gradle/src/org/netbeans/modules/gradle/api/execute/RunUtils.java
##########
@@ -100,6 +100,9 @@ public static FileObject extractFileObjectfromLookup(Lookup lookup) {
SingleMethod method = methods.iterator().next();
files.add(method.getFile());
}
+ if (files.isEmpty()) {
+ files.addAll(lookup.lookupAll(FileObject.class));
+ }
Review comment:
This is the same [fix as in Maven](78fbf67)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] asfgit merged pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2386: Cleanup of not just dependencies
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r491977373
##########
File path: ide/projectapi.nb/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.projectapi.nb
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/projectapi/nb/Bundle.properties
-OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb
-OpenIDE-Module-Specification-Version: 1.13
+OpenIDE-Module-Provides: org.netbeans.spi.project.ProjectManagerImplementation
Review comment:
@tzezula, there is no need to `OpenIDE-Module-Provides: cnb.org.netbeans.modules.projectapi.nb` it is provided automatically. Rather than that the module no provides implementation of `org.netbeans.spi.project.ProjectManagerImplementation`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists