You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/29 12:49:37 UTC

[GitHub] [flink] zentol opened a new pull request #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile

zentol opened a new pull request #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile
URL: https://github.com/apache/flink/pull/10959
 
 
   Removes the `add-dependencies-for-IDEA` profile and documents how to tell IntelliJ to put provided dependencies on the classpath, with an additional fallback should things not work as expected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile
URL: https://github.com/apache/flink/pull/10959#issuecomment-579741770
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit f5baa924e0d6678e10209e17b5637829ef0e6a72 (Wed Jan 29 12:51:41 UTC 2020)
   
   **Warnings:**
    * **6 pom.xml files were touched**: Check for build and licensing issues.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile

Posted by GitBox <gi...@apache.org>.
zentol commented on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile
URL: https://github.com/apache/flink/pull/10959#issuecomment-579798937
 
 
   the user facing docs already contain such a paragraph; and for flink-devs it shouldn't (?) be necessary.
   dependencies.md:
   ```
   It is highly recommended to keep the dependencies in scope *provided*. If they are not set to *provided*,
   the best case is that the resulting JAR becomes excessively large, because it also contains all Flink core
   dependencies. The worst case is that the Flink core dependencies that are added to the application's jar file
   clash with some of your own dependency versions (which is normally avoided through inverted classloading).
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile
URL: https://github.com/apache/flink/pull/10959#issuecomment-579750331
 
 
   <!--
   Meta data
   Hash:f5baa924e0d6678e10209e17b5637829ef0e6a72 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146589058 TriggerType:PUSH TriggerID:f5baa924e0d6678e10209e17b5637829ef0e6a72
   Hash:f5baa924e0d6678e10209e17b5637829ef0e6a72 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4654 TriggerType:PUSH TriggerID:f5baa924e0d6678e10209e17b5637829ef0e6a72
   -->
   ## CI report:
   
   * f5baa924e0d6678e10209e17b5637829ef0e6a72 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146589058) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4654) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile
URL: https://github.com/apache/flink/pull/10959#issuecomment-579750331
 
 
   <!--
   Meta data
   Hash:f5baa924e0d6678e10209e17b5637829ef0e6a72 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:f5baa924e0d6678e10209e17b5637829ef0e6a72
   -->
   ## CI report:
   
   * f5baa924e0d6678e10209e17b5637829ef0e6a72 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol merged pull request #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile
URL: https://github.com/apache/flink/pull/10959
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile
URL: https://github.com/apache/flink/pull/10959#issuecomment-579750331
 
 
   <!--
   Meta data
   Hash:f5baa924e0d6678e10209e17b5637829ef0e6a72 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146589058 TriggerType:PUSH TriggerID:f5baa924e0d6678e10209e17b5637829ef0e6a72
   Hash:f5baa924e0d6678e10209e17b5637829ef0e6a72 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4654 TriggerType:PUSH TriggerID:f5baa924e0d6678e10209e17b5637829ef0e6a72
   -->
   ## CI report:
   
   * f5baa924e0d6678e10209e17b5637829ef0e6a72 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146589058) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4654) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] StephanEwen commented on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile
URL: https://github.com/apache/flink/pull/10959#issuecomment-580676624
 
 
   Looks good.
   
   Side note: We might want to also add gradle quickstarts - as far as I know, there is more control to describe "include in classpath when running, but don't bundle into artifacts".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10959: [FLINK-15335] Replace `add-dependencies-for-IDEA` profile
URL: https://github.com/apache/flink/pull/10959#issuecomment-579750331
 
 
   <!--
   Meta data
   Hash:f5baa924e0d6678e10209e17b5637829ef0e6a72 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146589058 TriggerType:PUSH TriggerID:f5baa924e0d6678e10209e17b5637829ef0e6a72
   Hash:f5baa924e0d6678e10209e17b5637829ef0e6a72 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4654 TriggerType:PUSH TriggerID:f5baa924e0d6678e10209e17b5637829ef0e6a72
   -->
   ## CI report:
   
   * f5baa924e0d6678e10209e17b5637829ef0e6a72 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146589058) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4654) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services