You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "kush2439p (via GitHub)" <gi...@apache.org> on 2026/07/16 11:14:57 UTC
[PR] feat: implement consistent keyboard shortcuts and sequence navigation
kush2439p opened a new pull request, #4724:
URL: https://github.com/apache/streampipes/pull/4724
### Purpose
Implements #4695 — a consistent keyboard shortcut concept across StreamPipes.
- **Global navigation:** `g` then a letter jumps to a module (`g p` → Pipelines,
`g d` → Dashboards, `g c` → Adapters, `g e` → Charts, `g a` → Assets,
`g y` → Datasets, `g s` → Settings, `g h` → Home). Driven by a new
`shortcutKey` field on each module in `modules.yml`, generated into
`NavMenuService` — no duplicated route mapping.
- **Global utilities:** `?` opens Help, `Ctrl+B` / `Alt+B` toggles the sidebar.
- **Contextual shortcuts** (`E` to edit, `Ctrl+S` to save, etc.) unchanged.
- `KeyboardShortcutService` extended to support two-key sequences (1000ms
timeout) alongside existing single-key/modifier shortcuts, plus new `alt`
modifier support.
- Help page's Shortcuts tab now lists the navigation shortcuts dynamically
from `NavMenuService`, so it stays in sync with active modules.
- Added unit tests: sequence fire/timeout, sequence precedence over a
same-key contextual shortcut, alt-combo match, input-focus suppression.
### How to test
1. `npm install && npm run build-libraries && npm run build-dev`
2. Outside an input, press `g` then `p`/`d`/`c`/`e`/`a`/`y`/`s`/`h` → navigates.
3. Press `g`, wait >1s, then a letter → no navigation (timeout works).
4. Press `?` → Help opens; shortcuts listed there.
5. Press `Ctrl+B` / `Alt+B` → sidebar toggles.
6. `npm test` → `keyboard-shortcut.service.spec.ts` (6/6 passing).
### Remarks
While a `g`-sequence is pending, its second key always takes precedence over
a same-key contextual shortcut on that view (e.g. `g` `e` navigates to Charts
rather than triggering local edit mode). Intentional tradeoff for simplicity.
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: implement consistent keyboard shortcuts and sequence navigation
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe closed pull request #4724: feat: implement consistent keyboard shortcuts and sequence navigation
URL: https://github.com/apache/streampipes/pull/4724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: implement consistent keyboard shortcuts and sequence navigation
Posted by "kush2439p (via GitHub)" <gi...@apache.org>.
kush2439p commented on PR #4724:
URL: https://github.com/apache/streampipes/pull/4724#issuecomment-4991318748
Here is the implementation I've completed for this issue. This solution introduces consistent keyboard shortcuts across the modules. Please review it and let me know if any changes are needed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: implement consistent keyboard shortcuts and sequence navigation
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on PR #4724:
URL: https://github.com/apache/streampipes/pull/4724#issuecomment-5128325425
@kush2439p, thanks again for this PR. I created #4784 based on the changes introduced here, so I’ll close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: implement consistent keyboard shortcuts and sequence navigation
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on PR #4724:
URL: https://github.com/apache/streampipes/pull/4724#issuecomment-5103519393
Thank you very much, @kush2439p, for your work on this PR and for adding more shortcuts. I really like the direction!
While reviewing your changes, I had an idea for an alternative interaction that builds on your implementation and could make the shortcuts more discoverable. It uses Shift-based key hints that appear directly beside the navigation items.
The follow-up PR, #4784, is intended as a prototype for discussion and builds on the foundation you provided. I would greatly appreciate your feedback and any ideas for further improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org