You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "SadiJr (via GitHub)" <gi...@apache.org> on 2023/02/13 22:37:36 UTC

[GitHub] [cloudstack] SadiJr opened a new pull request, #7212: Improve logs when searching one storage pool to allocate a new volume

SadiJr opened a new pull request, #7212:
URL: https://github.com/apache/cloudstack/pull/7212

   ### Description
   
   The process of searching a storage pool to allocate a new volume does not have enough logs for effective troubleshooting. Thus, new logs were added in this process, aiming to facilitate future troubleshooting.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   It was tested in a local lab:
   
   1. I deployed new VMs, and also created new datadisks and attached to this VMs;
   2. I read the logs to see if they were improved;
   3. Before, the logs did not have enough information to perform an efficient troubleshooting;
   4. Now, with improved logs, the troubleshooting will be easier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland merged pull request #7212: Improve logs when searching one storage pool to allocate a new volume

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7212:
URL: https://github.com/apache/cloudstack/pull/7212


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] kiranchavala commented on pull request #7212: Improve logs when searching one storage pool to allocate a new volume

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7212:
URL: https://github.com/apache/cloudstack/pull/7212#issuecomment-1738521628

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7212: Improve logs when searching one storage pool to allocate a new volume

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7212:
URL: https://github.com/apache/cloudstack/pull/7212#issuecomment-1738610403

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7212: Improve logs when searching one storage pool to allocate a new volume

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7212:
URL: https://github.com/apache/cloudstack/pull/7212#issuecomment-1738522066

   @kiranchavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] codecov[bot] commented on pull request #7212: Improve logs when searching one storage pool to allocate a new volume

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7212:
URL: https://github.com/apache/cloudstack/pull/7212#issuecomment-1428861289

   # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#7212](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa8fa3c) into [main](https://codecov.io/gh/apache/cloudstack/commit/6d287793a550cb0b15fae965ec4942d77a89a60d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d28779) will **increase** coverage by `0.03%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #7212      +/-   ##
   ============================================
   + Coverage     12.63%   12.67%   +0.03%     
   - Complexity     8610     8639      +29     
   ============================================
     Files          2711     2716       +5     
     Lines        255748   256134     +386     
     Branches      39871    39926      +55     
   ============================================
   + Hits          32312    32456     +144     
   - Misses       219337   219550     +213     
   - Partials       4099     4128      +29     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...torage/allocator/AbstractStoragePoolAllocator.java](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9hbGxvY2F0b3IvQWJzdHJhY3RTdG9yYWdlUG9vbEFsbG9jYXRvci5qYXZh) | `8.69% <0.00%> (-0.20%)` | :arrow_down: |
   | [...ge/allocator/ClusterScopeStoragePoolAllocator.java](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9hbGxvY2F0b3IvQ2x1c3RlclNjb3BlU3RvcmFnZVBvb2xBbGxvY2F0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...k/storage/allocator/LocalStoragePoolAllocator.java](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9hbGxvY2F0b3IvTG9jYWxTdG9yYWdlUG9vbEFsbG9jYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...torage/allocator/ZoneWideStoragePoolAllocator.java](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9hbGxvY2F0b3IvWm9uZVdpZGVTdG9yYWdlUG9vbEFsbG9jYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ain/java/com/cloud/storage/StorageManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvU3RvcmFnZU1hbmFnZXJJbXBsLmphdmE=) | `0.88% <0.00%> (-0.01%)` | :arrow_down: |
   | [...ma/src/main/java/com/cloud/user/UserAccountVO.java](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91c2VyL1VzZXJBY2NvdW50Vk8uamF2YQ==) | `46.31% <0.00%> (-4.94%)` | :arrow_down: |
   | [...ne/schema/src/main/java/com/cloud/user/UserVO.java](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91c2VyL1VzZXJWTy5qYXZh) | `42.85% <0.00%> (-4.02%)` | :arrow_down: |
   | [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `36.28% <0.00%> (-3.99%)` | :arrow_down: |
   | [...om/cloud/api/query/dao/UserAccountJoinDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS9kYW8vVXNlckFjY291bnRKb2luRGFvSW1wbC5qYXZh) | `20.00% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/com/cloud/api/query/vo/UserAccountJoinVO.java](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS92by9Vc2VyQWNjb3VudEpvaW5WTy5qYXZh) | `27.08% <0.00%> (-0.58%)` | :arrow_down: |
   | ... and [30 more](https://codecov.io/gh/apache/cloudstack/pull/7212?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] SadiJr commented on pull request #7212: Improve logs when searching one storage pool to allocate a new volume

Posted by "SadiJr (via GitHub)" <gi...@apache.org>.
SadiJr commented on PR #7212:
URL: https://github.com/apache/cloudstack/pull/7212#issuecomment-1686702552

   > @SadiJr
   > 
   > Could you please provide a sample snippet of the new improved logs so that i can verify it.
   
   @kiranchavala sorry for the delay to answer you, sure I can provide some samples:
   
   ```log
   2023-08-21 11:15:21,778 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Trying to find suitable pools to allocate volume [29013bb4-c675-4e7b-ad2a-c782d0982b20] necessary to deploy VM [8a6c342c-e34c-4579-b5cb-15c254bddd50], using StoragePoolAllocator: [LocalStoragePoolAllocator].
   2023-08-21 11:15:21,783 DEBUG [o.a.c.s.a.AbstractStoragePoolAllocator] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Checking if storage pool [{"name":"datastore.201","uuid":"93dd766c21904b4cb58e8aa958a06bb2"}] is suitable to disk [DskChr[ROOT|21474836480|]].
   2023-08-21 11:15:21,787 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Volume [Vol[873|name=ROOT-874|vm=874|ROOT]] is not allocated to any pool. Cannot check compatibility with pool [{"name":"datastore.201","uuid":"93dd766c21904b4cb58e8aa958a06bb2"}].
   2023-08-21 11:15:21,793 INFO  [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Storage pool datastore.201 (11) does not supply IOPS capacity, assuming enough capacity
   2023-08-21 11:15:21,796 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Checking pool 11 for storage, totalSize: 590021132288, usedBytes: 5811208192, usedPct: 0.009849152638762512, disable threshold: 0.85
   2023-08-21 11:15:21,796 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Destination pool id: 11
   2023-08-21 11:15:21,818 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Pool ID for the volume with ID 873 is null
   2023-08-21 11:15:21,824 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Found storage pool datastore.201 of type VMFS with overprovisioning factor 2
   2023-08-21 11:15:21,824 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Total over provisioned capacity calculated is 2 * (549.50 GB) 590021132288
   2023-08-21 11:15:21,825 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Total capacity of the pool datastore.201 with ID 11 is (1.0732 TB) 1180042264576
   2023-08-21 11:15:21,826 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Checking pool: 11 for storage allocation , maxSize : (1.0732 TB) 1180042264576, totalAllocatedSize : (24.88 GB) 26717716480, askingSize : (20.00 GB) 21474836480, allocated disable threshold: 0.85
   2023-08-21 11:15:21,826 DEBUG [o.a.c.s.a.LocalStoragePoolAllocator] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Found suitable local storage pool [Pool[11|VMFS]] to allocate disk [DskChr[ROOT|21474836480|]] to it, adding to list.
   2023-08-21 11:15:21,827 DEBUG [o.a.c.s.a.AbstractStoragePoolAllocator] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Checking if storage pool [{"name":"datastore.200","uuid":"2ba84f326b2e36c8a0f3ce298558b23a"}] is suitable to disk [DskChr[ROOT|21474836480|]].
   2023-08-21 11:15:21,829 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Volume [Vol[873|name=ROOT-874|vm=874|ROOT]] is not allocated to any pool. Cannot check compatibility with pool [{"name":"datastore.200","uuid":"2ba84f326b2e36c8a0f3ce298558b23a"}].
   2023-08-21 11:15:21,831 INFO  [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Storage pool datastore.200 (12) does not supply IOPS capacity, assuming enough capacity
   2023-08-21 11:15:21,832 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Checking pool 12 for storage, totalSize: 590021132288, usedBytes: 96072630272, usedPct: 0.16282913444040037, disable threshold: 0.85
   2023-08-21 11:15:21,832 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Destination pool id: 12
   2023-08-21 11:15:21,838 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Pool ID for the volume with ID 873 is null
   2023-08-21 11:15:21,842 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Found storage pool datastore.200 of type VMFS with overprovisioning factor 2
   2023-08-21 11:15:21,842 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Total over provisioned capacity calculated is 2 * (549.50 GB) 590021132288
   2023-08-21 11:15:21,842 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Total capacity of the pool datastore.200 with ID 12 is (1.0732 TB) 1180042264576
   2023-08-21 11:15:21,843 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Checking pool: 12 for storage allocation , maxSize : (1.0732 TB) 1180042264576, totalAllocatedSize : (64.88 GB) 69667389440, askingSize : (20.00 GB) 21474836480, allocated disable threshold: 0.85
   2023-08-21 11:15:21,843 DEBUG [o.a.c.s.a.LocalStoragePoolAllocator] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) Found suitable local storage pool [Pool[12|VMFS]] to allocate disk [DskChr[ROOT|21474836480|]] to it, adding to list.
   2023-08-21 11:15:21,844 DEBUG [o.a.c.s.a.AbstractStoragePoolAllocator] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) LocalStoragePoolAllocator is returning [2] suitable storage pools [[{"name":"datastore.201","uuid":"93dd766c21904b4cb58e8aa958a06bb2"}, {"name":"datastore.200","uuid":"2ba84f326b2e36c8a0f3ce298558b23a"}]].
   2023-08-21 11:15:21,845 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (API-Job-Executor-17:ctx-e7a47918 job-7326 ctx-5edada67) (logid:c4f1b70c) StoragePoolAllocator [LocalStoragePoolAllocator] find 2 suitable pools to allocate volume [29013bb4-c675-4e7b-ad2a-c782d0982b20] necessary to deploy VM [8a6c342c-e34c-4579-b5cb-15c254bddd50].
   2023-08-21 11:15:23,037 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Trying to find suitable pools to allocate volume [29013bb4-c675-4e7b-ad2a-c782d0982b20] necessary to deploy VM [8a6c342c-e34c-4579-b5cb-15c254bddd50], using StoragePoolAllocator: [LocalStoragePoolAllocator].
   2023-08-21 11:15:23,041 DEBUG [o.a.c.s.a.AbstractStoragePoolAllocator] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Checking if storage pool [{"name":"datastore.200","uuid":"2ba84f326b2e36c8a0f3ce298558b23a"}] is suitable to disk [DskChr[ROOT|21474836480|]].
   2023-08-21 11:15:23,042 DEBUG [c.c.s.StorageManagerImpl] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Volume [Vol[873|name=ROOT-874|vm=874|ROOT]] is not allocated to any pool. Cannot check compatibility with pool [{"name":"datastore.200","uuid":"2ba84f326b2e36c8a0f3ce298558b23a"}].
   2023-08-21 11:15:23,045 INFO  [c.c.s.StorageManagerImpl] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Storage pool datastore.200 (12) does not supply IOPS capacity, assuming enough capacity
   2023-08-21 11:15:23,047 DEBUG [c.c.s.StorageManagerImpl] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Checking pool 12 for storage, totalSize: 590021132288, usedBytes: 96072630272, usedPct: 0.16282913444040037, disable threshold: 0.85
   2023-08-21 11:15:23,047 DEBUG [c.c.s.StorageManagerImpl] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Destination pool id: 12
   2023-08-21 11:15:23,054 DEBUG [c.c.s.StorageManagerImpl] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Pool ID for the volume with ID 873 is null
   2023-08-21 11:15:23,058 DEBUG [c.c.s.StorageManagerImpl] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Found storage pool datastore.200 of type VMFS with overprovisioning factor 2
   2023-08-21 11:15:23,058 DEBUG [c.c.s.StorageManagerImpl] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Total over provisioned capacity calculated is 2 * (549.50 GB) 590021132288
   2023-08-21 11:15:23,058 DEBUG [c.c.s.StorageManagerImpl] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Total capacity of the pool datastore.200 with ID 12 is (1.0732 TB) 1180042264576
   2023-08-21 11:15:23,060 DEBUG [c.c.s.StorageManagerImpl] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Checking pool: 12 for storage allocation , maxSize : (1.0732 TB) 1180042264576, totalAllocatedSize : (64.88 GB) 69667389440, askingSize : (20.00 GB) 21474836480, allocated disable threshold: 0.85
   2023-08-21 11:15:23,060 DEBUG [o.a.c.s.a.LocalStoragePoolAllocator] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) Found suitable local storage pool [Pool[12|VMFS]] to allocate disk [DskChr[ROOT|21474836480|]] to it, adding to list.
   2023-08-21 11:15:23,060 DEBUG [o.a.c.s.a.AbstractStoragePoolAllocator] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) LocalStoragePoolAllocator is returning [1] suitable storage pools [[{"name":"datastore.200","uuid":"2ba84f326b2e36c8a0f3ce298558b23a"}]].
   2023-08-21 11:15:23,061 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (Work-Job-Executor-26:ctx-a4f3804e job-7326/job-7327 ctx-9cf60e64) (logid:c4f1b70c) StoragePoolAllocator [LocalStoragePoolAllocator] find 1 suitable pools to allocate volume [29013bb4-c675-4e7b-ad2a-c782d0982b20] necessary to deploy VM [8a6c342c-e34c-4579-b5cb-15c254bddd50].
   ```
   
   Please tell me if you need more information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] kiranchavala commented on pull request #7212: Improve logs when searching one storage pool to allocate a new volume

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7212:
URL: https://github.com/apache/cloudstack/pull/7212#issuecomment-1463506572

   @SadiJr 
   
   Could you please provide a sample snippet of the new improved logs so that i can verify it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7212: Improve logs when searching one storage pool to allocate a new volume

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7212:
URL: https://github.com/apache/cloudstack/pull/7212#issuecomment-1428867767

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7212)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7212&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7212&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7212&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7212&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7212&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7212&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7212&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7212&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7212&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7212&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7212&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7212&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7212&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7212&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7212&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7212&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org