You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/27 09:23:12 UTC

[GitHub] [flink] slinkydeveloper opened a new pull request #18532: [FLINK-19845][connector-files] Prune FileSystemFormatFactory

slinkydeveloper opened a new pull request #18532:
URL: https://github.com/apache/flink/pull/18532


   ## What is the purpose of the change
   
   Remove `FileSystemFormatFactory`, superseded by `BulkWriterFormatFactory` and `BulkReaderFormatFactory` in previous releases.
   
   ## Brief change log
   
   * Remove `FileSystemFormatFactory`
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18532: [FLINK-19845][connector-files] Prune FileSystemFormatFactory

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #18532:
URL: https://github.com/apache/flink/pull/18532#issuecomment-1023012559


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b25902f8dd23f0a086d69364a1d84a18af4e0a4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8b25902f8dd23f0a086d69364a1d84a18af4e0a4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b25902f8dd23f0a086d69364a1d84a18af4e0a4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fapaul merged pull request #18532: [FLINK-19845][connector-files] Prune FileSystemFormatFactory

Posted by GitBox <gi...@apache.org>.

fapaul merged pull request #18532:
URL: https://github.com/apache/flink/pull/18532


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18532: [FLINK-19845][connector-files] Prune FileSystemFormatFactory

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #18532:
URL: https://github.com/apache/flink/pull/18532#issuecomment-1023010751

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 8b25902f8dd23f0a086d69364a1d84a18af4e0a4 (Thu Jan 27 09:28:32 UTC 2022)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18532: [FLINK-19845][connector-files] Prune FileSystemFormatFactory

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #18532:
URL: https://github.com/apache/flink/pull/18532#issuecomment-1023012559


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b25902f8dd23f0a086d69364a1d84a18af4e0a4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30290",
       "triggerID" : "8b25902f8dd23f0a086d69364a1d84a18af4e0a4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b25902f8dd23f0a086d69364a1d84a18af4e0a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30290) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18532: [FLINK-19845][connector-files] Prune FileSystemFormatFactory

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #18532:
URL: https://github.com/apache/flink/pull/18532#issuecomment-1023012559


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b25902f8dd23f0a086d69364a1d84a18af4e0a4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30290",
       "triggerID" : "8b25902f8dd23f0a086d69364a1d84a18af4e0a4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b25902f8dd23f0a086d69364a1d84a18af4e0a4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30290) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org