You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/01 02:39:31 UTC
[GitHub] [flink] chaojianok opened a new pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
chaojianok opened a new pull request #12797:
URL: https://github.com/apache/flink/pull/12797
[FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on a change in pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #12797:
URL: https://github.com/apache/flink/pull/12797#discussion_r449387782
##########
File path: docs/dev/table/connectors/blackhole.zh.md
##########
@@ -67,26 +67,26 @@ LIKE source_table (EXCLUDING ALL)
</div>
</div>
-Connector Options
+连接器选项
----------------
<table class="table table-bordered">
<thead>
<tr>
- <th class="text-left" style="width: 25%">Option</th>
- <th class="text-center" style="width: 8%">Required</th>
- <th class="text-center" style="width: 7%">Default</th>
- <th class="text-center" style="width: 10%">Type</th>
- <th class="text-center" style="width: 50%">Description</th>
+ <th class="text-left" style="width: 25%">选项</th>
+ <th class="text-center" style="width: 8%">必要</th>
Review comment:
这里翻译成 `是否必要` 或类似的会更好一些吗？，`默认` 那一列也类似
渲染完成会之后，这个相当于是 表头，下面的是内容。翻译成 `必要`的话，下面也是 `必要`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12797:
URL: https://github.com/apache/flink/pull/12797#issuecomment-652164701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141",
"triggerID" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"triggerType" : "PUSH"
}, {
"hash" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1319f3e445f1c3588b178712d50bc4070593ee0e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141)
* f6f557f37225aa8431b57c2e0031905c4aa90384 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #12797:
URL: https://github.com/apache/flink/pull/12797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chaojianok commented on pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
chaojianok commented on pull request #12797:
URL: https://github.com/apache/flink/pull/12797#issuecomment-653705322
Hi @klion26 , I've optimized this translation, please review again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12797:
URL: https://github.com/apache/flink/pull/12797#issuecomment-652164701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141",
"triggerID" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1319f3e445f1c3588b178712d50bc4070593ee0e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12797:
URL: https://github.com/apache/flink/pull/12797#issuecomment-652164701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1319f3e445f1c3588b178712d50bc4070593ee0e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12797:
URL: https://github.com/apache/flink/pull/12797#issuecomment-652164701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141",
"triggerID" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"triggerType" : "PUSH"
}, {
"hash" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4231",
"triggerID" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f557f37225aa8431b57c2e0031905c4aa90384 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4231)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12797:
URL: https://github.com/apache/flink/pull/12797#issuecomment-652153431
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1319f3e445f1c3588b178712d50bc4070593ee0e (Wed Jul 01 02:41:02 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12797:
URL: https://github.com/apache/flink/pull/12797#issuecomment-652164701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141",
"triggerID" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"triggerType" : "PUSH"
}, {
"hash" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4231",
"triggerID" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1319f3e445f1c3588b178712d50bc4070593ee0e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141)
* f6f557f37225aa8431b57c2e0031905c4aa90384 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4231)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12797:
URL: https://github.com/apache/flink/pull/12797#issuecomment-652164701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141",
"triggerID" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1319f3e445f1c3588b178712d50bc4070593ee0e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12797:
URL: https://github.com/apache/flink/pull/12797#issuecomment-652164701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141",
"triggerID" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"triggerType" : "PUSH"
}, {
"hash" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4231",
"triggerID" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"triggerType" : "PUSH"
}, {
"hash" : "1a86689fdd5a77090c343c9459fa58be46502991",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4234",
"triggerID" : "1a86689fdd5a77090c343c9459fa58be46502991",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f557f37225aa8431b57c2e0031905c4aa90384 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4231)
* 1a86689fdd5a77090c343c9459fa58be46502991 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4234)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12797:
URL: https://github.com/apache/flink/pull/12797#issuecomment-652164701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141",
"triggerID" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"triggerType" : "PUSH"
}, {
"hash" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4231",
"triggerID" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"triggerType" : "PUSH"
}, {
"hash" : "1a86689fdd5a77090c343c9459fa58be46502991",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1a86689fdd5a77090c343c9459fa58be46502991",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f557f37225aa8431b57c2e0031905c4aa90384 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4231)
* 1a86689fdd5a77090c343c9459fa58be46502991 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12797: [FLINK-18387] Translate "BlackHole SQL Connector" page into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12797:
URL: https://github.com/apache/flink/pull/12797#issuecomment-652164701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4141",
"triggerID" : "1319f3e445f1c3588b178712d50bc4070593ee0e",
"triggerType" : "PUSH"
}, {
"hash" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4231",
"triggerID" : "f6f557f37225aa8431b57c2e0031905c4aa90384",
"triggerType" : "PUSH"
}, {
"hash" : "1a86689fdd5a77090c343c9459fa58be46502991",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4234",
"triggerID" : "1a86689fdd5a77090c343c9459fa58be46502991",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a86689fdd5a77090c343c9459fa58be46502991 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4234)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org