You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/09 18:40:19 UTC
[GitHub] [spark] MaxGekk commented on issue #27491: [SPARK-30754][SQL] Reuse
results of floorDiv in calculations of floorMod in DateTimeUtils
MaxGekk commented on issue #27491: [SPARK-30754][SQL] Reuse results of floorDiv in calculations of floorMod in DateTimeUtils
URL: https://github.com/apache/spark/pull/27491#issuecomment-583878390
@kiszk The ops are not regular arithmetic `/` and `%`, they are lib calls. So, they present in byte code:
```
public microsToInstant(J)Ljava/time/Instant;
// parameter final us
L0
LINENUMBER 339 L0
LLOAD 1
LDC 1000000
INVOKESTATIC java/lang/Math.floorDiv (JJ)J
L1
LSTORE 3
L2
LINENUMBER 340 L2
LLOAD 1
LDC 1000000
INVOKESTATIC java/lang/Math.floorMod (JJ)J
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org