You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ferruzzi (via GitHub)" <gi...@apache.org> on 2023/10/13 23:06:13 UTC
[PR] D401 Support - Providers: DaskExecutor to Github (Inclusive) [airflow]
ferruzzi opened a new pull request, #34935:
URL: https://github.com/apache/airflow/pull/34935
Part of https://github.com/apache/airflow/issues/10742
D401 asserts "First line should be in imperative mood". This is a little opaque so upon further investigation what they want is:
```
[Docstring] prescribes the function or method's effect as a command:
("Do this", "Return that"), not as a description;
e.g. don't write "Returns the pathname ...".
```
We started with over two thousand violations in the repo so I'm going to take this in bites.
### PLEASE NOTE
There should be zero logic changes in this PR, only changes to docstrings and whitespace. If you see otherwise, please call it out.
### Included in this chunk
All files located in the following providers:
- daskexecutor
- databricks
- datadog
- dbt
- dingding
- discord
- docker
- elasticsearch
- exasol
- facebook
- ftp
- github
### To test
If you uncomment [this line](https://github.com/apache/airflow/blob/main/pyproject.toml#L61) and run pre-commit in main you will get over a thousand errors. After these changes, no files in the providers listed above should be on the list. After re-commenting that line and re-running pre-commits, there should be zero regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] D401 Support - Providers: DaskExecutor to Github (Inclusive) [airflow]
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi merged PR #34935:
URL: https://github.com/apache/airflow/pull/34935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org