You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/01 15:28:36 UTC

[GitHub] [kafka] divijvaidya opened a new pull request, #12933: MINOR: Optimize metric recording when quota check not required

divijvaidya opened a new pull request, #12933:
URL: https://github.com/apache/kafka/pull/12933

   In the selector code path, we record some values for some sensors which do not have any metric associated with them that requires quota. Yet, a redundant check for quotas is made which consumes ~0.7% of CPU time in the hot path as demonstrated by the flame graph below. 
   
   ![Screenshot 2022-12-01 at 15 46 52](https://user-images.githubusercontent.com/71267/205082727-29c1300d-48fa-475f-b736-45743a2291ba.png)
   
   This PR is a minor optimization which removes the redundant check for quotas in cases where it is not required in the hot path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac merged pull request #12933: MINOR: Optimize metric recording when quota check not required

Posted by GitBox <gi...@apache.org>.

dajac merged PR #12933:
URL: https://github.com/apache/kafka/pull/12933


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] divijvaidya commented on pull request #12933: MINOR: Optimize metric recording when quota check not required

Posted by GitBox <gi...@apache.org>.

divijvaidya commented on PR #12933:
URL: https://github.com/apache/kafka/pull/12933#issuecomment-1335021913

   @mimaison please take a look when you get a chance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #12933: MINOR: Optimize metric recording when quota check not required

Posted by GitBox <gi...@apache.org>.

dajac commented on PR #12933:
URL: https://github.com/apache/kafka/pull/12933#issuecomment-1337296109

   Merged to trunk. @divijvaidya Thanks for the patch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org