[GitHub] cordova-lib pull request #499: Cb 11960

[stevengill <gi...@git.apache.org>]

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/499#discussion_r97894565
  
    --- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
    @@ -697,18 +698,18 @@ describe('update config.xml to include platforms in pkg.json', function () {
                     return elem.name;
                 });
                 configEngArray = engNames.slice();
    -            // Expect 'ios' to be added to config.xml.
    -            expect(configEngArray.indexOf('ios')).toBeGreaterThan(-1);
    +            // Expect 'browser' to be added to config.xml.
    +            expect(configEngArray.indexOf('browser')).toBeGreaterThan(-1);
                 // Expect 'android' to still be in config.xml.
                 expect(configEngArray.indexOf('android')).toBeGreaterThan(-1);
                 // Expect config.xml array to have 2 elements (platforms).
                 expect(configEngArray.length === 2);
    -            // Check to make sure that 'ios' spec was added properly.
    -            expect(engines).toEqual([ { name: 'android', spec: '^3.1.0' },{ name: 'ios', spec: '^4.3.0' } ]);
    +            // Check to make sure that 'browser' spec was added properly.
    +            expect(engines).toEqual([ { name: 'android', spec: '^3.1.0' },{ name: 'browser', spec: '^4.3.0' } ]);
                 // No change to pkg.json dependencies.
    -            expect(pkgJson.dependencies).toEqual({ 'cordova-android' : '^3.1.0', 'cordova-ios' : '^4.3.0' });
    +            expect(pkgJson.dependencies).toEqual({ 'cordova-android' : '^3.1.0', 'cordova-browser' : '^4.3.0' });
                 expect(pkgJson.dependencies['cordova-android']).toEqual('^3.1.0');
    -            expect(pkgJson.dependencies['cordova-ios']).toEqual('^4.3.0');
    +            expect(pkgJson.dependencies['cordova-browser']).toEqual('^4.3.0');
    --- End diff --
    
    again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org