You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "apupier (via GitHub)" <gi...@apache.org> on 2024/03/05 10:25:03 UTC
[PR] Update apiversion of kamelets [camel-kamelets-examples]
apupier opened a new pull request, #72:
URL: https://github.com/apache/camel-kamelets-examples/pull/72
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update apiversion of kamelets [camel-kamelets-examples]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #72:
URL: https://github.com/apache/camel-kamelets-examples/pull/72#discussion_r1512794540
##########
camel-k/kafka-s3/kafka-not-secured-sink.kamelet.yaml:
##########
@@ -14,13 +14,13 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# ---------------------------------------------------------------------------
-apiVersion: camel.apache.org/v1alpha1
+apiVersion: camel.apache.org/v1
kind: Kamelet
metadata:
name: kafka-not-secured-sink
annotations:
camel.apache.org/kamelet.support.level: "Stable"
- camel.apache.org/catalog.version: "0.9.4"
+ camel.apache.org/catalog.version: "4.4.0"
Review Comment:
The last release for 2.2.x is based on 4.0.1
https://camel.apache.org/camel-k/2.2.x/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update apiversion of kamelets [camel-kamelets-examples]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #72:
URL: https://github.com/apache/camel-kamelets-examples/pull/72#discussion_r1512588286
##########
camel-k/kafka-s3/kafka-not-secured-sink.kamelet.yaml:
##########
@@ -14,13 +14,13 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# ---------------------------------------------------------------------------
-apiVersion: camel.apache.org/v1alpha1
+apiVersion: camel.apache.org/v1
kind: Kamelet
metadata:
name: kafka-not-secured-sink
annotations:
camel.apache.org/kamelet.support.level: "Stable"
- camel.apache.org/catalog.version: "0.9.4"
+ camel.apache.org/catalog.version: "4.4.0"
Review Comment:
That's an example of camel-k, so the version of catalog should be compatible with the version of camel k and there is not 4.4.0 yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update apiversion of kamelets [camel-kamelets-examples]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #72:
URL: https://github.com/apache/camel-kamelets-examples/pull/72#discussion_r1512775310
##########
camel-k/kafka-s3/kafka-not-secured-sink.kamelet.yaml:
##########
@@ -14,13 +14,13 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# ---------------------------------------------------------------------------
-apiVersion: camel.apache.org/v1alpha1
+apiVersion: camel.apache.org/v1
kind: Kamelet
metadata:
name: kafka-not-secured-sink
annotations:
camel.apache.org/kamelet.support.level: "Stable"
- camel.apache.org/catalog.version: "0.9.4"
+ camel.apache.org/catalog.version: "4.4.0"
Review Comment:
I was thinking it would be the Kamelet catalog version which has the 4.4.0 https://github.com/apache/camel-kamelets/releases/tag/v4.4.0
So to which kind of version it corresponds?
there is no 0.9.4 tag for camel k https://github.com/apache/camel-k/tags?after=1.0.0-nightly.202003261646 , neither Camel K runtime https://github.com/apache/camel-k-runtime/tags?after=camel-k-runtime-parent-1.0.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update apiversion of kamelets [camel-kamelets-examples]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #72:
URL: https://github.com/apache/camel-kamelets-examples/pull/72#discussion_r1512585233
##########
camel-k/kafka-s3/kafka-not-secured-sink.kamelet.yaml:
##########
@@ -14,13 +14,13 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# ---------------------------------------------------------------------------
-apiVersion: camel.apache.org/v1alpha1
+apiVersion: camel.apache.org/v1
kind: Kamelet
metadata:
name: kafka-not-secured-sink
annotations:
camel.apache.org/kamelet.support.level: "Stable"
- camel.apache.org/catalog.version: "0.9.4"
+ camel.apache.org/catalog.version: "4.4.0"
Review Comment:
or should we use main-SNAPSHOT like in other examples?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update apiversion of kamelets [camel-kamelets-examples]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #72:
URL: https://github.com/apache/camel-kamelets-examples/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org