You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/25 12:47:08 UTC
[GitHub] [kafka] jlprat opened a new pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
jlprat opened a new pull request #10758:
URL: https://github.com/apache/kafka/pull/10758
This is just a workaround to solve this problem while we are still using
JDK11.
Once moving to, presumably, JDK17 this change won't be needed
anymore and could be deleted safely. See https://bugs.openjdk.java.net/browse/JDK-8215291
This change includes a snippet of code copied from JDK 12+
I'm not sure if an extra header needs to be added for the piece of code I copied over, or if I would need to implement it from scratch.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10758:
URL: https://github.com/apache/kafka/pull/10758#issuecomment-849820046
Or just replace the code in this branch. Whatever you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10758:
URL: https://github.com/apache/kafka/pull/10758#issuecomment-847997038
Test failures were known flaky tests. Added a comment on the corresponding Jira's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10758:
URL: https://github.com/apache/kafka/pull/10758#issuecomment-849798924
Thanks for looking into this. Can we switch the release requirement to be Java 15 instead of Java 11 then? We can then switch to Java 17 once that's out and stick to that for a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10758:
URL: https://github.com/apache/kafka/pull/10758#issuecomment-849805196
Hi @ijuma, yes, if you would generate the Javadocs with JDK 15 (or 16) instead of 11, it would work (I tried it myself locally). Then one only needs to modify the `release.py` file to accomplish this.
I could create a PR with those changes if you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10758:
URL: https://github.com/apache/kafka/pull/10758#issuecomment-849820849
Closed in favor of https://github.com/apache/kafka/pull/10780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10758:
URL: https://github.com/apache/kafka/pull/10758#issuecomment-847839591
cc @ableegoldman as you opened the Jira ticket, maybe you'd like to review this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10758:
URL: https://github.com/apache/kafka/pull/10758#issuecomment-849813756
Yes, let's go with 15 since Kafka doesn't work with 16 yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10758:
URL: https://github.com/apache/kafka/pull/10758#issuecomment-848103904
To be honest I don't have much context on the javadocs but I will take a look. Maybe @ijuma can help review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat closed pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
Posted by GitBox <gi...@apache.org>.
jlprat closed pull request #10758:
URL: https://github.com/apache/kafka/pull/10758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10758:
URL: https://github.com/apache/kafka/pull/10758#issuecomment-849814665
Shall, I close this PR and open a new one with the modified `release.py`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10758:
URL: https://github.com/apache/kafka/pull/10758#issuecomment-848155893
Sure @ableegoldman , no worries. I just mentioned you as you were the one who created the ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org