You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by or...@apache.org on 2018/07/05 13:14:19 UTC
[2/2] qpid-broker-j git commit: QPID-8216: [Broker-J] Restore
reporting of pperational log message CHN-1011 about moving message to dead
letter queue
QPID-8216: [Broker-J] Restore reporting of pperational log message CHN-1011 about moving message to dead letter queue
Project: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/commit/38d5844e
Tree: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/tree/38d5844e
Diff: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/diff/38d5844e
Branch: refs/heads/master
Commit: 38d5844e5df591e8a2850f6e302763a764cc50c8
Parents: fbeb208
Author: Alex Rudyy <or...@apache.org>
Authored: Thu Jul 5 14:13:58 2018 +0100
Committer: Alex Rudyy <or...@apache.org>
Committed: Thu Jul 5 14:13:58 2018 +0100
----------------------------------------------------------------------
.../qpid/server/queue/QueueEntryImpl.java | 2 +-
.../server/queue/QueueEntryImplTestBase.java | 27 ++++++++++++++++++++
2 files changed, 28 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/38d5844e/broker-core/src/main/java/org/apache/qpid/server/queue/QueueEntryImpl.java
----------------------------------------------------------------------
diff --git a/broker-core/src/main/java/org/apache/qpid/server/queue/QueueEntryImpl.java b/broker-core/src/main/java/org/apache/qpid/server/queue/QueueEntryImpl.java
index aed7cfe..51cee72 100644
--- a/broker-core/src/main/java/org/apache/qpid/server/queue/QueueEntryImpl.java
+++ b/broker-core/src/main/java/org/apache/qpid/server/queue/QueueEntryImpl.java
@@ -615,7 +615,7 @@ public abstract class QueueEntryImpl implements QueueEntry
}
});
- int enqueues = result.send(txn, null);
+ int enqueues = result.send(txn, action);
if(autocommit)
{
http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/38d5844e/broker-core/src/test/java/org/apache/qpid/server/queue/QueueEntryImplTestBase.java
----------------------------------------------------------------------
diff --git a/broker-core/src/test/java/org/apache/qpid/server/queue/QueueEntryImplTestBase.java b/broker-core/src/test/java/org/apache/qpid/server/queue/QueueEntryImplTestBase.java
index 5f41c45..1bfafea 100644
--- a/broker-core/src/test/java/org/apache/qpid/server/queue/QueueEntryImplTestBase.java
+++ b/broker-core/src/test/java/org/apache/qpid/server/queue/QueueEntryImplTestBase.java
@@ -32,6 +32,7 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import java.lang.reflect.Field;
+import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
import java.util.UUID;
@@ -45,9 +46,11 @@ import org.apache.qpid.server.message.MessageInstance.StealableConsumerAcquiredS
import org.apache.qpid.server.message.MessageInstance.UnstealableConsumerAcquiredState;
import org.apache.qpid.server.message.MessageReference;
import org.apache.qpid.server.message.ServerMessage;
+import org.apache.qpid.server.model.AlternateBinding;
import org.apache.qpid.server.model.BrokerTestHelper;
import org.apache.qpid.server.model.Queue;
import org.apache.qpid.server.store.TransactionLogResource;
+import org.apache.qpid.server.util.Action;
import org.apache.qpid.server.util.StateChangeListener;
import org.apache.qpid.server.virtualhost.QueueManagingVirtualHost;
import org.apache.qpid.test.utils.UnitTestBase;
@@ -358,4 +361,28 @@ public abstract class QueueEntryImplTestBase extends UnitTestBase
next = next.getNextValidEntry();
assertNull("The next entry after the last should be null", next);
}
+
+ @Test
+ public void testRouteToAlternateInvokesAction()
+ {
+ String dlqName = "dlq";
+ Map<String, Object> dlqAttributes = new HashMap<>();
+ dlqAttributes.put(Queue.ID, UUID.randomUUID());
+ dlqAttributes.put(Queue.NAME, dlqName);
+ Queue<?> dlq = (Queue<?>) _queueEntry.getQueue().getVirtualHost().createChild(Queue.class, dlqAttributes);
+
+ final AlternateBinding alternateBinding = mock(AlternateBinding.class);
+ when(alternateBinding.getDestination()).thenReturn(dlqName);
+ _queueEntry.getQueue().setAttributes(Collections.singletonMap(Queue.ALTERNATE_BINDING, alternateBinding));
+
+ final Action<? super MessageInstance> action = mock(Action.class);
+ when(_queueEntry.getMessage().isResourceAcceptable(dlq)).thenReturn(true);
+ _queueEntry.acquire();
+ int enqueues = _queueEntry.routeToAlternate(action, null);
+
+ assertEquals("Unexpected number of enqueues", 1, enqueues);
+ verify(action).performAction(any());
+
+ assertEquals("Unexpected number of messages on DLQ", 1, dlq.getQueueDepthMessages());
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org