You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/04 21:36:01 UTC

[jira] [Work logged] (GOBBLIN-1350) Extend Gobblin State Store CLI to show deletes and fix script to properly invoke CLI tool

     [ https://issues.apache.org/jira/browse/GOBBLIN-1350?focusedWorklogId=530913&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530913 ]

ASF GitHub Bot logged work on GOBBLIN-1350:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jan/21 21:35
            Start Date: 04/Jan/21 21:35
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request #3189:
URL: https://github.com/apache/incubator-gobblin/pull/3189


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1350
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
    - Old state-store cli tool for viewing jobstates no longer worked with scripts, so refactored state operations into `JobStateStoreCli` class which handles reads/deletes from state stores
    - Implements a bulk delete feature requested by users
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   `JobStateStoreCliTest`
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 530913)
    Remaining Estimate: 0h
            Time Spent: 10m

> Extend Gobblin State Store CLI to show deletes and fix script to properly invoke CLI tool
> -----------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1350
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1350
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> - Prior CLI script could not instantiate the state store CLI due to parameter mismatch
> - Rewrites the CLI to consolidate the different execution modes better, clean up code
> - Adds delete functionality to job state based on file input



--
This message was sent by Atlassian Jira
(v8.3.4#803005)