[GitHub] [flink] yxu-valleytider edited a comment on issue #10653: [FLINK-13027][streaming]: StreamingFileSink bulk-encoded writer supports customized checkpoint policy

[GitBox <gi...@apache.org>]

yxu-valleytider edited a comment on issue #10653: [FLINK-13027][streaming]: StreamingFileSink bulk-encoded writer supports customized checkpoint policy
URL: https://github.com/apache/flink/pull/10653#issuecomment-568616531
 
 
   @kl0u thanks for the quick comments.  Yes I agree the main intention of the PR is to allow `forBulkFormat()` to specify a customized set of rolling policies. Hence I removed `FSizeCheckpointRollingPolicy` and related test which makes the PR shorter. 
   
   As for the documentation, there's a significant amount of changes in [master](https://ci.apache.org/projects/flink/flink-docs-master/dev/connectors/streamfile_sink.html). Compared with the [stable version](https://ci.apache.org/projects/flink/flink-docs-stable/dev/connectors/streamfile_sink.html), there is no mentioning of wording such as:  `Bulk-encoding formats can only be combined with the OnCheckpointRollingPolicy`.   But I can certainly add a few sentences to strengthen that `BulkFormatBuilder` allows specifying customized policies derived from `CheckpointRollingPolicy`.   Does that sound good ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services