You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by rp...@apache.org on 2010/05/31 09:20:22 UTC
svn commit: r949676 - /httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c
Author: rpluem
Date: Mon May 31 07:20:21 2010
New Revision: 949676
URL: http://svn.apache.org/viewvc?rev=949676&view=rev
Log:
* Fix compiler warning about "incompatible pointer type"
Modified:
httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c
Modified: httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c?rev=949676&r1=949675&r2=949676&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c (original)
+++ httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c Mon May 31 07:20:21 2010
@@ -785,7 +785,7 @@ void modssl_var_extract_dns(apr_table_t
* success and writes the string to the given bio. */
static int dump_extn_value(BIO *bio, ASN1_OCTET_STRING *str)
{
- const unsigned char *pp = str->data;
+ unsigned char *pp = str->data;
ASN1_STRING *ret = ASN1_STRING_new();
int rv = 0;
Re: svn commit: r949676 - /httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c
Posted by Dr Stephen Henson <sh...@oss-institute.org>.
On 31/05/2010 08:20, rpluem@apache.org wrote:
> Author: rpluem
> Date: Mon May 31 07:20:21 2010
> New Revision: 949676
>
> URL: http://svn.apache.org/viewvc?rev=949676&view=rev
> Log:
> * Fix compiler warning about "incompatible pointer type"
>
> Modified:
> httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c
>
> Modified: httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c?rev=949676&r1=949675&r2=949676&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c (original)
> +++ httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c Mon May 31 07:20:21 2010
> @@ -785,7 +785,7 @@ void modssl_var_extract_dns(apr_table_t
> * success and writes the string to the given bio. */
> static int dump_extn_value(BIO *bio, ASN1_OCTET_STRING *str)
> {
> - const unsigned char *pp = str->data;
> + unsigned char *pp = str->data;
> ASN1_STRING *ret = ASN1_STRING_new();
> int rv = 0;
>
This actually depends on the version of OpenSSL in use. The ASN1 decoding
functions were constified in 1.0.0 so you get a warning in 1.0.0 if you make
that change or in 0.9.8 with the original...
Steve.
--
Dr Stephen N. Henson. Senior Technical/Cryptography Advisor,
Open Source Software Institute: www.oss-institute.org
OpenSSL Core team: www.openssl.org