You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Michael Heuer (JIRA)" <ji...@apache.org> on 2006/06/23 20:14:29 UTC

[jira] Created: (DBCP-191) [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0

[dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0
----------------------------------------------------------------------

         Key: DBCP-191
         URL: http://issues.apache.org/jira/browse/DBCP-191
     Project: Commons Dbcp
        Type: Improvement

 Environment: $ java -version
java version "1.6.0-rc"
Java(TM) SE Runtime Environment (build 1.6.0-rc-b87)
Java HotSpot(TM) Client VM (build 1.6.0-rc-b87, mixed mode, sharing)

$ java -version
java version "1.6.0-rc"
Java(TM) SE Runtime Environment (build 1.6.0-rc-b89)
Java HotSpot(TM) Client VM (build 1.6.0-rc-b89, mixed mode, sharing)
    Reporter: Michael Heuer
    Priority: Minor


Just a heads up, [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0, even with maven.compile.source and maven.compile.target properties set to something appropriate.


$ maven java:compile
 __  __
|  \/  |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
|_|  |_\__,_|\_/\___|_||_|  v. 1.0.2

java:prepare-filesystem:
    [mkdir] Created dir: working/commons-dbcp/target/classes

java:compile:
    [echo] Compiling to working/commons-dbcp/target/classes
    [echo]
==========================================================

  NOTE: Targetting JVM 1.6, classes
  will not run on earlier JVMs

==========================================================

    [javac] Compiling 39 source files to working/commons-dbcp/target/classes
working/commons-dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java:43: org.apache.commons.dbcp.BasicDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
public class BasicDataSource implements DataSource {
       ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/ConnectionImpl.java: 40: org.apache.commons.dbcp.cpdsadapter.ConnectionImpl is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
class ConnectionImpl implements Connection {
^
working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PooledConnectionImpl.java:42: org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl is not abstract and does not override abstract method removeStatementEventListener(javax.sql.StatementEventListener) in javax.sql.PooledConnection
class PooledConnectionImpl
^
working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingConnection.java:50: org.apache.commons.dbcp.DelegatingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
public class DelegatingConnection extends AbandonedTrace
       ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/DriverAdapterCPDS.java:85: org.apache.commons.dbcp.cpdsadapter.DriverAdapterCPDS is not abstract and does not override abstract method getQueryObjectGenerator() in javax.sql.CommonDataSource
public class DriverAdapterCPDS
       ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:45: org.apache.commons.dbcp.DelegatingStatement is not abstract and does not override abstract method isPoolable() in java.sql.Statement
public class DelegatingStatement extends AbandonedTrace implements Statement {
       ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:130: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
    protected boolean isClosed() {
                      ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingPreparedStatement.java:49: org.apache.commons.dbcp.DelegatingPreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
public class DelegatingPreparedStatement extends DelegatingStatement
       ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolablePreparedStatement.java:40: org.apache.commons.dbcp.PoolablePreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
public class PoolablePreparedStatement extends DelegatingPreparedStatement implements PreparedStatement {
       ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PoolablePreparedStatementStub.java:33: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
class PoolablePreparedStatementStub extends PoolablePreparedStatement {
^
working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/PerUserPoolDataSource.java:51: org.apache.commons.dbcp.datasources.PerUserPoolDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
public class PerUserPoolDataSource
       ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/SharedPoolDataSource.java:45: org.apache.commons.dbcp.datasources.SharedPoolDataSource is not abstract and does not override abstract method
 <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
public class SharedPoolDataSource
       ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingCallableStatement.java:52: org.apache.commons.dbcp.DelegatingCallableStatement is not abstract and does not override abstract method setCharacterStream(java.lang.String,java.io.Reader,long) in java.sql.CallableStatement
public class DelegatingCallableStatement extends DelegatingPreparedStatement
       ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingResultSet.java:54: org.apache.commons.dbcp.DelegatingResultSet is not abstract and does not override abstract method updateNClob(java.lang.String,java.io.Reader,long) in java.sql.ResultSet
public class DelegatingResultSet extends AbandonedTrace implements ResultSet {
       ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingConnection.java:41: org.apache.commons.dbcp.PoolingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
public class PoolingConnection extends DelegatingConnection implements Connection, KeyedPoolableObjectFactory {
       ^
working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingDataSource.java:44: org.apache.commons.dbcp.PoolingDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
public class PoolingDataSource implements DataSource {
       ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
16 errors

BUILD FAILED
File...... .maven/cache/maven-java-plugin-1.5/plugin.jelly
Element... ant:javac
Line...... 63
Column.... 48
Compile failed; see the compiler error output for details.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (DBCP-191) [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0

Posted by "Michael Heuer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DBCP-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514825 ] 

Michael Heuer commented on DBCP-191:
------------------------------------

Attached is a patch that allows commons-dbcp and its tests to compile under maven with jdk 1.6/JDBC 4.0.

A couple of potential gotchas:

 - boolean isClosed() is now a public method on DelegatingStatement, was protected

 - several JDBC interfaces now implement java.sql.Wrapper, which contains generics language features


and to-dos:

 - questionable implemention of boolean Wrapper.isWrapperFor(Class<?> iface) and <T> T Wrapper.unwrap(Class<T> iface) in some classes (e.g. BasicDataSource has a dataSource but is it considered a wrapper?)

 - conditional compilation for /* JDBC_4_ANT_KEY... */ tags via the ant build

 - create a separate svn branch?

> [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0
> ----------------------------------------------------------------------
>
>                 Key: DBCP-191
>                 URL: https://issues.apache.org/jira/browse/DBCP-191
>             Project: Commons Dbcp
>          Issue Type: Improvement
>         Environment: $ java -version
> java version "1.6.0-rc"
> Java(TM) SE Runtime Environment (build 1.6.0-rc-b87)
> Java HotSpot(TM) Client VM (build 1.6.0-rc-b87, mixed mode, sharing)
> $ java -version
> java version "1.6.0-rc"
> Java(TM) SE Runtime Environment (build 1.6.0-rc-b89)
> Java HotSpot(TM) Client VM (build 1.6.0-rc-b89, mixed mode, sharing)
>            Reporter: Michael Heuer
>            Priority: Minor
>             Fix For: 1.3
>
>
> Just a heads up, [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0, even with maven.compile.source and maven.compile.target properties set to something appropriate.
> $ maven java:compile
>  __  __
> |  \/  |__ _Apache__ ___
> | |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
> |_|  |_\__,_|\_/\___|_||_|  v. 1.0.2
> java:prepare-filesystem:
>     [mkdir] Created dir: working/commons-dbcp/target/classes
> java:compile:
>     [echo] Compiling to working/commons-dbcp/target/classes
>     [echo]
> ==========================================================
>   NOTE: Targetting JVM 1.6, classes
>   will not run on earlier JVMs
> ==========================================================
>     [javac] Compiling 39 source files to working/commons-dbcp/target/classes
> working/commons-dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java:43: org.apache.commons.dbcp.BasicDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class BasicDataSource implements DataSource {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/ConnectionImpl.java: 40: org.apache.commons.dbcp.cpdsadapter.ConnectionImpl is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> class ConnectionImpl implements Connection {
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PooledConnectionImpl.java:42: org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl is not abstract and does not override abstract method removeStatementEventListener(javax.sql.StatementEventListener) in javax.sql.PooledConnection
> class PooledConnectionImpl
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingConnection.java:50: org.apache.commons.dbcp.DelegatingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> public class DelegatingConnection extends AbandonedTrace
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/DriverAdapterCPDS.java:85: org.apache.commons.dbcp.cpdsadapter.DriverAdapterCPDS is not abstract and does not override abstract method getQueryObjectGenerator() in javax.sql.CommonDataSource
> public class DriverAdapterCPDS
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:45: org.apache.commons.dbcp.DelegatingStatement is not abstract and does not override abstract method isPoolable() in java.sql.Statement
> public class DelegatingStatement extends AbandonedTrace implements Statement {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:130: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
>     protected boolean isClosed() {
>                       ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingPreparedStatement.java:49: org.apache.commons.dbcp.DelegatingPreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
> public class DelegatingPreparedStatement extends DelegatingStatement
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolablePreparedStatement.java:40: org.apache.commons.dbcp.PoolablePreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
> public class PoolablePreparedStatement extends DelegatingPreparedStatement implements PreparedStatement {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PoolablePreparedStatementStub.java:33: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
> class PoolablePreparedStatementStub extends PoolablePreparedStatement {
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/PerUserPoolDataSource.java:51: org.apache.commons.dbcp.datasources.PerUserPoolDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class PerUserPoolDataSource
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/SharedPoolDataSource.java:45: org.apache.commons.dbcp.datasources.SharedPoolDataSource is not abstract and does not override abstract method
>  <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class SharedPoolDataSource
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingCallableStatement.java:52: org.apache.commons.dbcp.DelegatingCallableStatement is not abstract and does not override abstract method setCharacterStream(java.lang.String,java.io.Reader,long) in java.sql.CallableStatement
> public class DelegatingCallableStatement extends DelegatingPreparedStatement
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingResultSet.java:54: org.apache.commons.dbcp.DelegatingResultSet is not abstract and does not override abstract method updateNClob(java.lang.String,java.io.Reader,long) in java.sql.ResultSet
> public class DelegatingResultSet extends AbandonedTrace implements ResultSet {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingConnection.java:41: org.apache.commons.dbcp.PoolingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> public class PoolingConnection extends DelegatingConnection implements Connection, KeyedPoolableObjectFactory {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingDataSource.java:44: org.apache.commons.dbcp.PoolingDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class PoolingDataSource implements DataSource {
>        ^
> Note: Some input files use or override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 16 errors
> BUILD FAILED
> File...... .maven/cache/maven-java-plugin-1.5/plugin.jelly
> Element... ant:javac
> Line...... 63
> Column.... 48
> Compile failed; see the compiler error output for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (DBCP-191) [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0

Posted by "Michael Heuer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DBCP-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Heuer updated DBCP-191:
-------------------------------

    Attachment: patch.txt

patch against nightly for 23 July 2007, or in other words

$ svn co --revision '{2007-07-23}' ...
...
$ svn diff . > patch.txt

> [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0
> ----------------------------------------------------------------------
>
>                 Key: DBCP-191
>                 URL: https://issues.apache.org/jira/browse/DBCP-191
>             Project: Commons Dbcp
>          Issue Type: Improvement
>         Environment: $ java -version
> java version "1.6.0-rc"
> Java(TM) SE Runtime Environment (build 1.6.0-rc-b87)
> Java HotSpot(TM) Client VM (build 1.6.0-rc-b87, mixed mode, sharing)
> $ java -version
> java version "1.6.0-rc"
> Java(TM) SE Runtime Environment (build 1.6.0-rc-b89)
> Java HotSpot(TM) Client VM (build 1.6.0-rc-b89, mixed mode, sharing)
>            Reporter: Michael Heuer
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: patch.txt
>
>
> Just a heads up, [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0, even with maven.compile.source and maven.compile.target properties set to something appropriate.
> $ maven java:compile
>  __  __
> |  \/  |__ _Apache__ ___
> | |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
> |_|  |_\__,_|\_/\___|_||_|  v. 1.0.2
> java:prepare-filesystem:
>     [mkdir] Created dir: working/commons-dbcp/target/classes
> java:compile:
>     [echo] Compiling to working/commons-dbcp/target/classes
>     [echo]
> ==========================================================
>   NOTE: Targetting JVM 1.6, classes
>   will not run on earlier JVMs
> ==========================================================
>     [javac] Compiling 39 source files to working/commons-dbcp/target/classes
> working/commons-dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java:43: org.apache.commons.dbcp.BasicDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class BasicDataSource implements DataSource {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/ConnectionImpl.java: 40: org.apache.commons.dbcp.cpdsadapter.ConnectionImpl is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> class ConnectionImpl implements Connection {
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PooledConnectionImpl.java:42: org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl is not abstract and does not override abstract method removeStatementEventListener(javax.sql.StatementEventListener) in javax.sql.PooledConnection
> class PooledConnectionImpl
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingConnection.java:50: org.apache.commons.dbcp.DelegatingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> public class DelegatingConnection extends AbandonedTrace
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/DriverAdapterCPDS.java:85: org.apache.commons.dbcp.cpdsadapter.DriverAdapterCPDS is not abstract and does not override abstract method getQueryObjectGenerator() in javax.sql.CommonDataSource
> public class DriverAdapterCPDS
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:45: org.apache.commons.dbcp.DelegatingStatement is not abstract and does not override abstract method isPoolable() in java.sql.Statement
> public class DelegatingStatement extends AbandonedTrace implements Statement {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:130: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
>     protected boolean isClosed() {
>                       ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingPreparedStatement.java:49: org.apache.commons.dbcp.DelegatingPreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
> public class DelegatingPreparedStatement extends DelegatingStatement
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolablePreparedStatement.java:40: org.apache.commons.dbcp.PoolablePreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
> public class PoolablePreparedStatement extends DelegatingPreparedStatement implements PreparedStatement {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PoolablePreparedStatementStub.java:33: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
> class PoolablePreparedStatementStub extends PoolablePreparedStatement {
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/PerUserPoolDataSource.java:51: org.apache.commons.dbcp.datasources.PerUserPoolDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class PerUserPoolDataSource
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/SharedPoolDataSource.java:45: org.apache.commons.dbcp.datasources.SharedPoolDataSource is not abstract and does not override abstract method
>  <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class SharedPoolDataSource
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingCallableStatement.java:52: org.apache.commons.dbcp.DelegatingCallableStatement is not abstract and does not override abstract method setCharacterStream(java.lang.String,java.io.Reader,long) in java.sql.CallableStatement
> public class DelegatingCallableStatement extends DelegatingPreparedStatement
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingResultSet.java:54: org.apache.commons.dbcp.DelegatingResultSet is not abstract and does not override abstract method updateNClob(java.lang.String,java.io.Reader,long) in java.sql.ResultSet
> public class DelegatingResultSet extends AbandonedTrace implements ResultSet {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingConnection.java:41: org.apache.commons.dbcp.PoolingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> public class PoolingConnection extends DelegatingConnection implements Connection, KeyedPoolableObjectFactory {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingDataSource.java:44: org.apache.commons.dbcp.PoolingDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class PoolingDataSource implements DataSource {
>        ^
> Note: Some input files use or override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 16 errors
> BUILD FAILED
> File...... .maven/cache/maven-java-plugin-1.5/plugin.jelly
> Element... ant:javac
> Line...... 63
> Column.... 48
> Compile failed; see the compiler error output for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (DBCP-191) [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0

Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DBCP-191?page=all ]

Phil Steitz updated DBCP-191:
-----------------------------

    Fix Version: 1.3

> [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0
> ----------------------------------------------------------------------
>
>          Key: DBCP-191
>          URL: http://issues.apache.org/jira/browse/DBCP-191
>      Project: Commons Dbcp
>         Type: Improvement

>  Environment: $ java -version
> java version "1.6.0-rc"
> Java(TM) SE Runtime Environment (build 1.6.0-rc-b87)
> Java HotSpot(TM) Client VM (build 1.6.0-rc-b87, mixed mode, sharing)
> $ java -version
> java version "1.6.0-rc"
> Java(TM) SE Runtime Environment (build 1.6.0-rc-b89)
> Java HotSpot(TM) Client VM (build 1.6.0-rc-b89, mixed mode, sharing)
>     Reporter: Michael Heuer
>     Priority: Minor
>      Fix For: 1.3

>
> Just a heads up, [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0, even with maven.compile.source and maven.compile.target properties set to something appropriate.
> $ maven java:compile
>  __  __
> |  \/  |__ _Apache__ ___
> | |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
> |_|  |_\__,_|\_/\___|_||_|  v. 1.0.2
> java:prepare-filesystem:
>     [mkdir] Created dir: working/commons-dbcp/target/classes
> java:compile:
>     [echo] Compiling to working/commons-dbcp/target/classes
>     [echo]
> ==========================================================
>   NOTE: Targetting JVM 1.6, classes
>   will not run on earlier JVMs
> ==========================================================
>     [javac] Compiling 39 source files to working/commons-dbcp/target/classes
> working/commons-dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java:43: org.apache.commons.dbcp.BasicDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class BasicDataSource implements DataSource {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/ConnectionImpl.java: 40: org.apache.commons.dbcp.cpdsadapter.ConnectionImpl is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> class ConnectionImpl implements Connection {
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PooledConnectionImpl.java:42: org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl is not abstract and does not override abstract method removeStatementEventListener(javax.sql.StatementEventListener) in javax.sql.PooledConnection
> class PooledConnectionImpl
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingConnection.java:50: org.apache.commons.dbcp.DelegatingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> public class DelegatingConnection extends AbandonedTrace
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/DriverAdapterCPDS.java:85: org.apache.commons.dbcp.cpdsadapter.DriverAdapterCPDS is not abstract and does not override abstract method getQueryObjectGenerator() in javax.sql.CommonDataSource
> public class DriverAdapterCPDS
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:45: org.apache.commons.dbcp.DelegatingStatement is not abstract and does not override abstract method isPoolable() in java.sql.Statement
> public class DelegatingStatement extends AbandonedTrace implements Statement {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:130: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
>     protected boolean isClosed() {
>                       ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingPreparedStatement.java:49: org.apache.commons.dbcp.DelegatingPreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
> public class DelegatingPreparedStatement extends DelegatingStatement
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolablePreparedStatement.java:40: org.apache.commons.dbcp.PoolablePreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
> public class PoolablePreparedStatement extends DelegatingPreparedStatement implements PreparedStatement {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PoolablePreparedStatementStub.java:33: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
> class PoolablePreparedStatementStub extends PoolablePreparedStatement {
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/PerUserPoolDataSource.java:51: org.apache.commons.dbcp.datasources.PerUserPoolDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class PerUserPoolDataSource
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/SharedPoolDataSource.java:45: org.apache.commons.dbcp.datasources.SharedPoolDataSource is not abstract and does not override abstract method
>  <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class SharedPoolDataSource
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingCallableStatement.java:52: org.apache.commons.dbcp.DelegatingCallableStatement is not abstract and does not override abstract method setCharacterStream(java.lang.String,java.io.Reader,long) in java.sql.CallableStatement
> public class DelegatingCallableStatement extends DelegatingPreparedStatement
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingResultSet.java:54: org.apache.commons.dbcp.DelegatingResultSet is not abstract and does not override abstract method updateNClob(java.lang.String,java.io.Reader,long) in java.sql.ResultSet
> public class DelegatingResultSet extends AbandonedTrace implements ResultSet {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingConnection.java:41: org.apache.commons.dbcp.PoolingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> public class PoolingConnection extends DelegatingConnection implements Connection, KeyedPoolableObjectFactory {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingDataSource.java:44: org.apache.commons.dbcp.PoolingDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class PoolingDataSource implements DataSource {
>        ^
> Note: Some input files use or override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 16 errors
> BUILD FAILED
> File...... .maven/cache/maven-java-plugin-1.5/plugin.jelly
> Element... ant:javac
> Line...... 63
> Column.... 48
> Compile failed; see the compiler error output for details.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (DBCP-191) [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0

Posted by "Georgi Georgiev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DBCP-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477772 ] 

Georgi Georgiev commented on DBCP-191:
--------------------------------------

What would the proper way to fix this issue be? It is quite simple to implement the missing methods but that would break compatibility with Java 5.

> [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0
> ----------------------------------------------------------------------
>
>                 Key: DBCP-191
>                 URL: https://issues.apache.org/jira/browse/DBCP-191
>             Project: Commons Dbcp
>          Issue Type: Improvement
>         Environment: $ java -version
> java version "1.6.0-rc"
> Java(TM) SE Runtime Environment (build 1.6.0-rc-b87)
> Java HotSpot(TM) Client VM (build 1.6.0-rc-b87, mixed mode, sharing)
> $ java -version
> java version "1.6.0-rc"
> Java(TM) SE Runtime Environment (build 1.6.0-rc-b89)
> Java HotSpot(TM) Client VM (build 1.6.0-rc-b89, mixed mode, sharing)
>            Reporter: Michael Heuer
>            Priority: Minor
>             Fix For: 1.3
>
>
> Just a heads up, [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0, even with maven.compile.source and maven.compile.target properties set to something appropriate.
> $ maven java:compile
>  __  __
> |  \/  |__ _Apache__ ___
> | |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
> |_|  |_\__,_|\_/\___|_||_|  v. 1.0.2
> java:prepare-filesystem:
>     [mkdir] Created dir: working/commons-dbcp/target/classes
> java:compile:
>     [echo] Compiling to working/commons-dbcp/target/classes
>     [echo]
> ==========================================================
>   NOTE: Targetting JVM 1.6, classes
>   will not run on earlier JVMs
> ==========================================================
>     [javac] Compiling 39 source files to working/commons-dbcp/target/classes
> working/commons-dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java:43: org.apache.commons.dbcp.BasicDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class BasicDataSource implements DataSource {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/ConnectionImpl.java: 40: org.apache.commons.dbcp.cpdsadapter.ConnectionImpl is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> class ConnectionImpl implements Connection {
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PooledConnectionImpl.java:42: org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl is not abstract and does not override abstract method removeStatementEventListener(javax.sql.StatementEventListener) in javax.sql.PooledConnection
> class PooledConnectionImpl
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingConnection.java:50: org.apache.commons.dbcp.DelegatingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> public class DelegatingConnection extends AbandonedTrace
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/DriverAdapterCPDS.java:85: org.apache.commons.dbcp.cpdsadapter.DriverAdapterCPDS is not abstract and does not override abstract method getQueryObjectGenerator() in javax.sql.CommonDataSource
> public class DriverAdapterCPDS
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:45: org.apache.commons.dbcp.DelegatingStatement is not abstract and does not override abstract method isPoolable() in java.sql.Statement
> public class DelegatingStatement extends AbandonedTrace implements Statement {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingStatement.java:130: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
>     protected boolean isClosed() {
>                       ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingPreparedStatement.java:49: org.apache.commons.dbcp.DelegatingPreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
> public class DelegatingPreparedStatement extends DelegatingStatement
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolablePreparedStatement.java:40: org.apache.commons.dbcp.PoolablePreparedStatement is not abstract and does not override abstract method setCharacterStream(int,java.io.Reader,long) in java.sql.PreparedStatement
> public class PoolablePreparedStatement extends DelegatingPreparedStatement implements PreparedStatement {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/cpdsadapter/PoolablePreparedStatementStub.java:33: isClosed() in org.apache.commons.dbcp.DelegatingStatement cannot implement isClosed() in java.sql.Statement; attempting to assign weaker access privileges; was public
> class PoolablePreparedStatementStub extends PoolablePreparedStatement {
> ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/PerUserPoolDataSource.java:51: org.apache.commons.dbcp.datasources.PerUserPoolDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class PerUserPoolDataSource
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/datasources/SharedPoolDataSource.java:45: org.apache.commons.dbcp.datasources.SharedPoolDataSource is not abstract and does not override abstract method
>  <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class SharedPoolDataSource
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingCallableStatement.java:52: org.apache.commons.dbcp.DelegatingCallableStatement is not abstract and does not override abstract method setCharacterStream(java.lang.String,java.io.Reader,long) in java.sql.CallableStatement
> public class DelegatingCallableStatement extends DelegatingPreparedStatement
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/DelegatingResultSet.java:54: org.apache.commons.dbcp.DelegatingResultSet is not abstract and does not override abstract method updateNClob(java.lang.String,java.io.Reader,long) in java.sql.ResultSet
> public class DelegatingResultSet extends AbandonedTrace implements ResultSet {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingConnection.java:41: org.apache.commons.dbcp.PoolingConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
> public class PoolingConnection extends DelegatingConnection implements Connection, KeyedPoolableObjectFactory {
>        ^
> working/commons-dbcp/src/java/org/apache/commons/dbcp/PoolingDataSource.java:44: org.apache.commons.dbcp.PoolingDataSource is not abstract and does not override abstract method <T>createQueryObject(java.lang.Class<T>,javax.sql.DataSource) in javax.sql.DataSource
> public class PoolingDataSource implements DataSource {
>        ^
> Note: Some input files use or override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 16 errors
> BUILD FAILED
> File...... .maven/cache/maven-java-plugin-1.5/plugin.jelly
> Element... ant:javac
> Line...... 63
> Column.... 48
> Compile failed; see the compiler error output for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org