[DIH] SqlEntityProcessor does not recognize onError attribute

[Sascha Szott <sz...@zib.de>]

Hi all,

as stated in the Solr-WIKI, Solr 1.4 allows it to specify an onError 
attribute for *each* entity listed in the data config file (it is 
considered as one of the default attributes).

Unfortunately, the SqlEntityProcessor does not recognize the attribute's 
value -- i.e., in case an SQL exception is thrown somewhere inside the 
constructor of ResultSetIterators (which is an inner class of 
JdbcDataSource), Solr's import exits immediately, even though onError is 
set to continue or skip.

Why are database related exceptions (e.g., table does not exists, or an 
error in query syntax occurs) not being covered by the onError 
attribute? In my opinion, use cases exist that will profit from such an 
exception handling inside of Solr (for example, in cases where the 
existence of certain database tables or views is not predictable).

Should I raise an JIRA-issue about this?

-Sascha

Re: [DIH] SqlEntityProcessor does not recognize onError attribute

[Sascha Szott <sz...@zib.de>]

Hi,

Noble Paul നോബിള്‍ नोब्ळ् wrote:
> On Mon, Nov 9, 2009 at 4:24 PM, Sascha Szott <sz...@zib.de> wrote:
>> Hi all,
>>
>> as stated in the Solr-WIKI, Solr 1.4 allows it to specify an onError
>> attribute for *each* entity listed in the data config file (it is considered
>> as one of the default attributes).
>>
>> Unfortunately, the SqlEntityProcessor does not recognize the attribute's
>> value -- i.e., in case an SQL exception is thrown somewhere inside the
>> constructor of ResultSetIterators (which is an inner class of
>> JdbcDataSource), Solr's import exits immediately, even though onError is set
>> to continue or skip.
>>
>> Why are database related exceptions (e.g., table does not exists, or an
>> error in query syntax occurs) not being covered by the onError attribute? In
>> my opinion, use cases exist that will profit from such an exception handling
>> inside of Solr (for example, in cases where the existence of certain
>> database tables or views is not predictable).
> We thought DB errors are not to be ignored because errors such as
> table does not exist can be really serious.
In principle, I agree with you, though I would consider it as a 
programmer's responsibility to be aware of it (in case he/she sets 
onError to skip or continue).

>> Should I raise an JIRA-issue about this?
> Raise an issue it can be fixed
I've created issue SOLR-1549.

Best,
Sascha

Re: [DIH] SqlEntityProcessor does not recognize onError attribute

[Noble Paul നോബിള്‍ नोब्ळ् <no...@corp.aol.com>]

On Mon, Nov 9, 2009 at 4:24 PM, Sascha Szott <sz...@zib.de> wrote:
> Hi all,
>
> as stated in the Solr-WIKI, Solr 1.4 allows it to specify an onError
> attribute for *each* entity listed in the data config file (it is considered
> as one of the default attributes).
>
> Unfortunately, the SqlEntityProcessor does not recognize the attribute's
> value -- i.e., in case an SQL exception is thrown somewhere inside the
> constructor of ResultSetIterators (which is an inner class of
> JdbcDataSource), Solr's import exits immediately, even though onError is set
> to continue or skip.
>
> Why are database related exceptions (e.g., table does not exists, or an
> error in query syntax occurs) not being covered by the onError attribute? In
> my opinion, use cases exist that will profit from such an exception handling
> inside of Solr (for example, in cases where the existence of certain
> database tables or views is not predictable).
We thought DB errors are not to be ignored because errors such as
table does not exist can be really serious.

>
> Should I raise an JIRA-issue about this?
Raise an issue it can be fixed
>
> -Sascha
>
>
>



-- 
-----------------------------------------------------
Noble Paul | Principal Engineer| AOL | http://aol.com