You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2017/10/19 23:00:52 UTC

[GitHub] beam pull request #4019: [BEAM-3066] Make the main seed job standalone

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/4019

    [BEAM-3066] Make the main seed job standalone

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @jasonkuster 
    
    This is a follow-up to #4004. That PR added a standalone seed job that would continue to work even if I screwed up the main seed job. But if I understand correctly, the "standalone seed job" does not have permissions to create new jobs. I didn't realize this at the time, but either way my plan would be mostly unchanged. The standalone job did succeed, so it has the power to restore existing jobs if not to create new ones.
    
    This switches the main seed job to have the same contents, leaving the standalone job as a backup so we can restore easily.
    
    The end goal is this: we "never" touch the seed job again, and no tweaking of other jobs can affect it. Then we can start to improve them safely.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam seed-job-swap

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4019.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4019
    
----
commit 987eb53977a9f47efa2ad6fdd58dc9611779c2fc
Author: Kenneth Knowles <ke...@apache.org>
Date:   2017-10-19T22:55:03Z

    Make the main seed job standalone

----


---

[GitHub] beam pull request #4019: [BEAM-3066] Make the main seed job standalone

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/4019


---