You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/23 09:29:17 UTC

[GitHub] mseeger commented on a change in pull request #12904: support upper triangular matrices in linalg

mseeger commented on a change in pull request #12904: support upper triangular matrices in linalg
URL: https://github.com/apache/incubator-mxnet/pull/12904#discussion_r227296584
 
 

 ##########
 File path: src/operator/tensor/la_op_inline.h
 ##########
 @@ -35,17 +35,23 @@ using namespace mshadow;
 // Helper functions.
 struct CopyLowerToUpper {
 
 Review comment:
   OK, I see below that using this inverse argument is quite elegant.
   But consider renaming the function to something like CopyTriangleToOppositeTriangle,
   and then inverse -> source_upper, or so?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services