You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <jo...@gmail.com> on 2016/01/05 00:02:49 UTC
Review Request 41897: Upgrade to the latest zk point release.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41897/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Repository: aurora
Description
-------
This is enabled by https://reviews.apache.org/r/41895/ which
isolated the kerberos configuration.
build.gradle | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Diffs
-----
build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75
Diff: https://reviews.apache.org/r/41897/diff/
Testing
-------
Both `./build-support/jenkins/build.sh` and
`./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
green locally.
Thanks,
John Sirois
Re: Review Request 41897: Upgrade to the latest zk point release.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41897/#review112676
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 4, 2016, 11:02 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41897/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 11:02 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is enabled by https://reviews.apache.org/r/41895/ which
> isolated the kerberos configuration.
>
> build.gradle | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75
>
> Diff: https://reviews.apache.org/r/41897/diff/
>
>
> Testing
> -------
>
> Both `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
> green locally.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41897: Upgrade to the latest zk point release.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41897/#review112702
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Jan. 4, 2016, 3:44 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41897/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 3:44 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is enabled by https://reviews.apache.org/r/41895/ which
> isolated the kerberos configuration.
>
> build.gradle | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> NEWS c0c454d080023a2e2796022f957a4d47bdb87b41
> build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75
>
> Diff: https://reviews.apache.org/r/41897/diff/
>
>
> Testing
> -------
>
> Both `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
> green locally.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41897: Upgrade to the latest zk point release.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41897/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 4:44 p.m.)
Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Bill Farner.
Changes
-------
Fixup NEWS to reflect upgraded upgrade.
NEWS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Repository: aurora
Description
-------
This is enabled by https://reviews.apache.org/r/41895/ which
isolated the kerberos configuration.
build.gradle | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Diffs (updated)
-----
NEWS c0c454d080023a2e2796022f957a4d47bdb87b41
build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75
Diff: https://reviews.apache.org/r/41897/diff/
Testing
-------
Both `./build-support/jenkins/build.sh` and
`./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
green locally.
Thanks,
John Sirois
Re: Review Request 41897: Upgrade to the latest zk point release.
Posted by John Sirois <jo...@gmail.com>.
> On Jan. 4, 2016, 4:17 p.m., Stephan Erb wrote:
> > News file needs updating too :-)
Good call - change coming as well as an updated reviews list.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41897/#review112679
-----------------------------------------------------------
On Jan. 4, 2016, 4:02 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41897/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 4:02 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is enabled by https://reviews.apache.org/r/41895/ which
> isolated the kerberos configuration.
>
> build.gradle | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75
>
> Diff: https://reviews.apache.org/r/41897/diff/
>
>
> Testing
> -------
>
> Both `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
> green locally.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41897: Upgrade to the latest zk point release.
Posted by John Sirois <jo...@gmail.com>.
> On Jan. 4, 2016, 4:17 p.m., Stephan Erb wrote:
> > News file needs updating too :-)
>
> John Sirois wrote:
> Good call - change coming as well as an updated reviews list.
Fixed.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41897/#review112679
-----------------------------------------------------------
On Jan. 4, 2016, 4:02 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41897/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 4:02 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is enabled by https://reviews.apache.org/r/41895/ which
> isolated the kerberos configuration.
>
> build.gradle | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75
>
> Diff: https://reviews.apache.org/r/41897/diff/
>
>
> Testing
> -------
>
> Both `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
> green locally.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41897: Upgrade to the latest zk point release.
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41897/#review112679
-----------------------------------------------------------
News file needs updating too :-)
- Stephan Erb
On Jan. 5, 2016, 12:02 a.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41897/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 12:02 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is enabled by https://reviews.apache.org/r/41895/ which
> isolated the kerberos configuration.
>
> build.gradle | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75
>
> Diff: https://reviews.apache.org/r/41897/diff/
>
>
> Testing
> -------
>
> Both `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
> green locally.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41897: Upgrade to the latest zk point release.
Posted by John Sirois <jo...@gmail.com>.
> On Jan. 4, 2016, 4:20 p.m., Aurora ReviewBot wrote:
> > Master (8706a78) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_standard_transitions [32mPASSED[0m
> > src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_nonstandard_transitions [32mPASSED[0m
> > src/test/python/apache/thermos/observer/test_task_observer.py::TaskObserverTest::test_run_loop [31mFAILED[0m
> >
> > ==================== FAILURES ====================
> > _________ TaskObserverTest.test_run_loop _________
> >
> > self = <test_task_observer.TaskObserverTest testMethod=test_run_loop>
> >
> > [1m def test_run_loop(self):[0m
> > [1m """Test observer run loop."""[0m
> > [1m mock_task_detector = create_autospec(spec=ObserverTaskDetector)[0m
> > [1m with patch([0m
> > [1m "apache.thermos.observer.task_observer.ObserverTaskDetector",[0m
> > [1m return_value=mock_task_detector) as mock_detector:[0m
> > [1m with patch('threading._Event.wait') as mock_wait:[0m
> > [1m [0m
> > [1m run_count = 3[0m
> > [1m interval = 15[0m
> > [1m observer = TaskObserver(mock_detector, interval=Amount(interval, Time.SECONDS))[0m
> > [1m observer.start()[0m
> > [1m while len(mock_wait.mock_calls) < run_count:[0m
> > [1m pass[0m
> > [1m [0m
> > [1m observer.stop()[0m
> > [1m [0m
> > [1m> assert len(mock_task_detector.mock_calls) >= run_count[0m
> > [1m[31mE AssertionError: assert 1 >= 3[0m
> > [1m[31mE + where 1 = len([call.refresh()])[0m
> > [1m[31mE + where [call.refresh()] = <MagicMock spec='ObserverTaskDetector' id='140389955602192'>.mock_calls[0m
> >
> > src/test/python/apache/thermos/observer/test_task_observer.py:42: AssertionError
> > generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.observer.observer.xml
> > [1m[31m======= 1 failed, 3 passed in 0.25 seconds =======[0m
> >
> > FAILURE
> >
> >
> > 23:20:37 04:05 [complete][31m
> > FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
>
> John Sirois wrote:
> I found no jira issue but will file shortly: Anyone recall if this is known flaky?
Filed https://issues.apache.org/jira/browse/AURORA-1570
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41897/#review112683
-----------------------------------------------------------
On Jan. 4, 2016, 4:44 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41897/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 4:44 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is enabled by https://reviews.apache.org/r/41895/ which
> isolated the kerberos configuration.
>
> build.gradle | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> NEWS c0c454d080023a2e2796022f957a4d47bdb87b41
> build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75
>
> Diff: https://reviews.apache.org/r/41897/diff/
>
>
> Testing
> -------
>
> Both `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
> green locally.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41897: Upgrade to the latest zk point release.
Posted by John Sirois <jo...@gmail.com>.
> On Jan. 4, 2016, 4:20 p.m., Aurora ReviewBot wrote:
> > Master (8706a78) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_standard_transitions [32mPASSED[0m
> > src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_nonstandard_transitions [32mPASSED[0m
> > src/test/python/apache/thermos/observer/test_task_observer.py::TaskObserverTest::test_run_loop [31mFAILED[0m
> >
> > ==================== FAILURES ====================
> > _________ TaskObserverTest.test_run_loop _________
> >
> > self = <test_task_observer.TaskObserverTest testMethod=test_run_loop>
> >
> > [1m def test_run_loop(self):[0m
> > [1m """Test observer run loop."""[0m
> > [1m mock_task_detector = create_autospec(spec=ObserverTaskDetector)[0m
> > [1m with patch([0m
> > [1m "apache.thermos.observer.task_observer.ObserverTaskDetector",[0m
> > [1m return_value=mock_task_detector) as mock_detector:[0m
> > [1m with patch('threading._Event.wait') as mock_wait:[0m
> > [1m [0m
> > [1m run_count = 3[0m
> > [1m interval = 15[0m
> > [1m observer = TaskObserver(mock_detector, interval=Amount(interval, Time.SECONDS))[0m
> > [1m observer.start()[0m
> > [1m while len(mock_wait.mock_calls) < run_count:[0m
> > [1m pass[0m
> > [1m [0m
> > [1m observer.stop()[0m
> > [1m [0m
> > [1m> assert len(mock_task_detector.mock_calls) >= run_count[0m
> > [1m[31mE AssertionError: assert 1 >= 3[0m
> > [1m[31mE + where 1 = len([call.refresh()])[0m
> > [1m[31mE + where [call.refresh()] = <MagicMock spec='ObserverTaskDetector' id='140389955602192'>.mock_calls[0m
> >
> > src/test/python/apache/thermos/observer/test_task_observer.py:42: AssertionError
> > generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.observer.observer.xml
> > [1m[31m======= 1 failed, 3 passed in 0.25 seconds =======[0m
> >
> > FAILURE
> >
> >
> > 23:20:37 04:05 [complete][31m
> > FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
I found no jira issue but will file shortly: Anyone recall if this is known flaky?
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41897/#review112683
-----------------------------------------------------------
On Jan. 4, 2016, 4:02 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41897/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 4:02 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is enabled by https://reviews.apache.org/r/41895/ which
> isolated the kerberos configuration.
>
> build.gradle | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75
>
> Diff: https://reviews.apache.org/r/41897/diff/
>
>
> Testing
> -------
>
> Both `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
> green locally.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41897: Upgrade to the latest zk point release.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41897/#review112683
-----------------------------------------------------------
Master (8706a78) is red with this patch.
./build-support/jenkins/build.sh
src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_standard_transitions [32mPASSED[0m
src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_nonstandard_transitions [32mPASSED[0m
src/test/python/apache/thermos/observer/test_task_observer.py::TaskObserverTest::test_run_loop [31mFAILED[0m
==================== FAILURES ====================
_________ TaskObserverTest.test_run_loop _________
self = <test_task_observer.TaskObserverTest testMethod=test_run_loop>
[1m def test_run_loop(self):[0m
[1m """Test observer run loop."""[0m
[1m mock_task_detector = create_autospec(spec=ObserverTaskDetector)[0m
[1m with patch([0m
[1m "apache.thermos.observer.task_observer.ObserverTaskDetector",[0m
[1m return_value=mock_task_detector) as mock_detector:[0m
[1m with patch('threading._Event.wait') as mock_wait:[0m
[1m [0m
[1m run_count = 3[0m
[1m interval = 15[0m
[1m observer = TaskObserver(mock_detector, interval=Amount(interval, Time.SECONDS))[0m
[1m observer.start()[0m
[1m while len(mock_wait.mock_calls) < run_count:[0m
[1m pass[0m
[1m [0m
[1m observer.stop()[0m
[1m [0m
[1m> assert len(mock_task_detector.mock_calls) >= run_count[0m
[1m[31mE AssertionError: assert 1 >= 3[0m
[1m[31mE + where 1 = len([call.refresh()])[0m
[1m[31mE + where [call.refresh()] = <MagicMock spec='ObserverTaskDetector' id='140389955602192'>.mock_calls[0m
src/test/python/apache/thermos/observer/test_task_observer.py:42: AssertionError
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.observer.observer.xml
[1m[31m======= 1 failed, 3 passed in 0.25 seconds =======[0m
FAILURE
23:20:37 04:05 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 4, 2016, 11:02 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41897/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 11:02 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is enabled by https://reviews.apache.org/r/41895/ which
> isolated the kerberos configuration.
>
> build.gradle | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75
>
> Diff: https://reviews.apache.org/r/41897/diff/
>
>
> Testing
> -------
>
> Both `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
> green locally.
>
>
> Thanks,
>
> John Sirois
>
>