You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/14 13:39:41 UTC

[GitHub] [flink] XComp opened a new pull request #19080: [FLINK-26121][runtime] Adds clearUnhandledEvents() method

XComp opened a new pull request #19080:
URL: https://github.com/apache/flink/pull/19080


   This is a missed-out 1.14 backport of PR #18844 only including the actually test fix.
   
   ## What is the purpose of the change
   
   We experienced some ZK connection issue which resulted in a
   SUSPEND and a RECONNECT event which were not handled and,
   therefore, stayed in the queue blocking a thread for the
   second event (because the capacity of the internally used
   ArrayBlockingQueue is set to 1). Shutting down the driver
   initiates a shutdown of the ExecutorService which is used
   for the listeners internally (see
   ZooKeeperLeaderRetrievalDriver.close()). The blocking thread
   will cause a fatal error through an InterruptedException.
   The test will fail due to the fatal error in the end.
   
   Cleaning unhandled events at the end of the test run fix the
   issue. Additionally, the tests were aligned by moving generic
   code into a helper method.
   
   ## Brief change log
   
   * Adds queue cleanup method to each test
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19080: [FLINK-26121][BP-1.14][runtime] Adds clearUnhandledEvents() method

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19080:
URL: https://github.com/apache/flink/pull/19080#issuecomment-1066898353


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "68cdd79975c3c7904b8448189930cb574a19cfa5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "68cdd79975c3c7904b8448189930cb574a19cfa5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 68cdd79975c3c7904b8448189930cb574a19cfa5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #19080: [FLINK-26121][BP-1.14][runtime] Adds clearUnhandledEvents() method

Posted by GitBox <gi...@apache.org>.
XComp merged pull request #19080:
URL: https://github.com/apache/flink/pull/19080


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19080: [FLINK-26121][BP-1.14][runtime] Adds clearUnhandledEvents() method

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19080:
URL: https://github.com/apache/flink/pull/19080#issuecomment-1066898353


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "68cdd79975c3c7904b8448189930cb574a19cfa5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33028",
       "triggerID" : "68cdd79975c3c7904b8448189930cb574a19cfa5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 68cdd79975c3c7904b8448189930cb574a19cfa5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33028) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19080: [FLINK-26121][BP-1.14][runtime] Adds clearUnhandledEvents() method

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19080:
URL: https://github.com/apache/flink/pull/19080#issuecomment-1066898353


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "68cdd79975c3c7904b8448189930cb574a19cfa5",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33028",
       "triggerID" : "68cdd79975c3c7904b8448189930cb574a19cfa5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 68cdd79975c3c7904b8448189930cb574a19cfa5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33028) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org