[GitHub] [zeppelin] AyWa commented on a change in pull request #3339: [ZEPPELIN-4078] handle ipython kernel crash

[GitBox <gi...@apache.org>]

AyWa commented on a change in pull request #3339: [ZEPPELIN-4078] handle ipython kernel crash
URL: https://github.com/apache/zeppelin/pull/3339#discussion_r267684636
 
 

 ##########
 File path: python/src/main/resources/grpc/python/ipython_server.py
 ##########
 @@ -146,10 +160,16 @@ def serve(port):
     server.start()
     ipython.start()
     try:
-        while True:
-            time.sleep(_ONE_DAY_IN_SECONDS)
+        while ipython.isKernelAlive():
 
 Review comment:
   We have multiple options when we figure out that the kernel die:
   - return an error then kill the process (this pr is doing that)
   - restart the kernel ?
   
   The challenge with 1, is that we maybe need to add a new status to the `status` grpc method. like `shutdown`. We can check this status before running like in the `checkIpythonProcessAndRestartIfDead` 
   
   The challenge with 2 is that our execute thread will always be stuck. and we might have no way to kill it.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services