You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2025/08/07 17:39:28 UTC
[PR] GH-45449: [R][CI] Remove OpenSSL 1.x builds [arrow]
thisisnic opened a new pull request, #47280:
URL: https://github.com/apache/arrow/pull/47280
### Rationale for this change
### What changes are included in this PR?
### Are these changes tested?
### Are there any user-facing changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45449: [R][CI] Remove OpenSSL 1.x builds [arrow]
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #47280:
URL: https://github.com/apache/arrow/pull/47280#discussion_r2262815309
##########
r/tools/nixlibs.R:
##########
@@ -271,12 +267,9 @@ test_for_curl_and_openssl <- "
#include <curl/curl.h>
#include <openssl/opensslv.h>
-#if OPENSSL_VERSION_NUMBER < 0x10002000L
+#if OPENSSL_VERSION_NUMBER < 0x30000000L
#error OpenSSL version too old
#endif
-#if OPENSSL_VERSION_NUMBER < 0x10100000L
-#error Using OpenSSL version 1.0
-#endif
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
#error Using OpenSSL version 3
#endif
Review Comment:
I think you need to remove this now, you either have openssl 3.0 or not
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45449: [R][CI] Remove OpenSSL 1.x builds [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47280:
URL: https://github.com/apache/arrow/pull/47280#issuecomment-3165159073
:warning: GitHub issue #45449 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45449: [R][CI] Remove OpenSSL 1.x builds [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #47280:
URL: https://github.com/apache/arrow/pull/47280#issuecomment-3167897109
Thanks for the review @nealrichardson! Just FYI, I'm now no longer entirely convinced that the source of the problem was definitely OpenSSL 1.X compatibility and I'm going to look into that a bit more or ping someone else, but given we were considering removing OpenSSL 1.X support anyway, it might be worth doing this just to simplify the code we have to maintain - what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45449: [R][CI] Remove OpenSSL 1.x builds [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed pull request #47280: GH-45449: [R][CI] Remove OpenSSL 1.x builds
URL: https://github.com/apache/arrow/pull/47280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45449: [R][CI] Remove OpenSSL 1.x builds [arrow]
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #47280:
URL: https://github.com/apache/arrow/pull/47280#discussion_r2262817926
##########
r/tools/nixlibs.R:
##########
@@ -320,10 +313,9 @@ get_macos_openssl_dir <- function() {
# (built with newer devtoolset but older glibc (2.17) for broader compatibility, like manylinux2014)
determine_binary_from_stderr <- function(errs) {
if (is.null(attr(errs, "status"))) {
- # There was no error in compiling: so we found libcurl and OpenSSL >= 1.1,
- # openssl is < 3.0
- lg("Found libcurl and OpenSSL >= 1.1")
- return("openssl-1.1")
+ # There was no error in compiling: so we found libcurl and OpenSSL >= 3.0,
Review Comment:
See comment above, if you don't remove that second check, the script will error on openssl >= 3.0 so this won't be true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45449: [R][CI] Remove OpenSSL 1.x builds [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #47280:
URL: https://github.com/apache/arrow/pull/47280#issuecomment-3170563156
This fix isn't actually needed; superseded by #47299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45449: [R][CI] Remove OpenSSL 1.x builds [arrow]
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #47280:
URL: https://github.com/apache/arrow/pull/47280#discussion_r2262822094
##########
r/tools/nixlibs.R:
##########
@@ -336,16 +328,9 @@ determine_binary_from_stderr <- function(errs) {
lg("OpenSSL not found")
return(NULL)
} else if (any(grepl("OpenSSL version too old", errs))) {
- lg("OpenSSL found but version >= 1.0.2 is required for some features")
+ lg("OpenSSL found but version >= 3.0.0 is required for some features")
return(NULL)
# Else, determine which other binary will work
- } else if (any(grepl("Using OpenSSL version 1.0", errs))) {
- if (on_macos) {
- lg("OpenSSL 1.0 is not supported on macOS")
- return(NULL)
- }
- lg("Found libcurl and OpenSSL < 1.1")
- return("openssl-1.0")
} else if (any(grepl("Using OpenSSL version 3", errs))) {
Review Comment:
And I think you can remove this last `else if`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org