[GitHub] [incubator-livy] rliuamzn commented on a diff in pull request #358: [LIVY-896] Livy not capture spark-submit error exit if timing is right

[GitBox <gi...@apache.org>]

rliuamzn commented on code in PR #358:
URL: https://github.com/apache/incubator-livy/pull/358#discussion_r1014529813


##########
server/src/test/scala/org/apache/livy/utils/SparkYarnAppSpec.scala:
##########
@@ -269,6 +269,90 @@ class SparkYarnAppSpec extends FunSpec with LivyBaseUnitTestSuite {
       }
     }
 
+    it("should end with state failed when spark submit failed but Yarn reports application SUCCESS (LIVY-896)") {

Review Comment:
   Could you shorten this line to ```should end with state failed when spark submit failed but Yarn reports SUCCESS```? This line exceeds 100 chars and failed the build for me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org