[GitHub] [druid] suneet-s commented on a diff in pull request #12439: Vectorize numeric latest aggregators

[GitBox <gi...@apache.org>]

suneet-s commented on code in PR #12439:
URL: https://github.com/apache/druid/pull/12439#discussion_r858080166


##########
processing/src/test/java/org/apache/druid/query/aggregation/last/FloatLastVectorAggregatorTest.java:
##########
@@ -65,14 +65,15 @@ public void setup()
   @Test
   public void initValueShouldBeNegInf()
   {
-    target.initValue(buf, 0);
+    target.init(buf, 0);

Review Comment:
   This test looks incorrect. When we call init, the timestamp should be inserted at `position`
   
   ```suggestion
       target.initValue(buf, 0);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org