[GitHub] [incubator-echarts] Ende93 commented on a change in pull request #10201: fix(geo): use `label.formatter` instead of ` label.normal.formatter`

[GitBox <gi...@apache.org>]

Ende93 commented on a change in pull request #10201: fix(geo):  use `label.formatter` instead of ` label.normal.formatter`
URL: https://github.com/apache/incubator-echarts/pull/10201#discussion_r272421400
 
 

 ##########
 File path: src/coord/geo/GeoModel.js
 ##########
 @@ -148,7 +148,7 @@ var GeoModel = ComponentModel.extend({
      */
     getFormattedLabel: function (name, status) {
         var regionModel = this.getRegionModel(name);
-        var formatter = regionModel.get('label.' + status + '.formatter');
+        var formatter = regionModel.get(['label', status === 'normal' ? '' : status, 'formatter'].join('.'));
 
 Review comment:
   fixed and I also fix the formatter params & str replacement, please review it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org