You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/04 12:13:54 UTC
[GitHub] [arrow] rymurr opened a new pull request #7095: ARROW-8664: [Java] Add flag to skip null check
rymurr opened a new pull request #7095:
URL: https://github.com/apache/arrow/pull/7095
All Vector containers should skip null check when null
check flag is enabled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7095: ARROW-8664: [Java] Add flag to skip null check
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7095:
URL: https://github.com/apache/arrow/pull/7095#issuecomment-623428933
https://issues.apache.org/jira/browse/ARROW-8664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield closed pull request #7095: ARROW-8664: [Java] Add flag to skip null check
Posted by GitBox <gi...@apache.org>.
emkornfield closed pull request #7095:
URL: https://github.com/apache/arrow/pull/7095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7095: ARROW-8664: [Java] Add flag to skip null check
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7095:
URL: https://github.com/apache/arrow/pull/7095#issuecomment-629011438
Thanks @rymurr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rdblue commented on pull request #7095: ARROW-8664: [Java] Add flag to skip null check
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #7095:
URL: https://github.com/apache/arrow/pull/7095#issuecomment-624378129
Looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rymurr commented on pull request #7095: ARROW-8664: [Java] Add flag to skip null check
Posted by GitBox <gi...@apache.org>.
rymurr commented on pull request #7095:
URL: https://github.com/apache/arrow/pull/7095#issuecomment-625760957
> This looks good to me. +1.
>
> > In the past adding a getUnsafe method was discussed. What do you think about that?
>
> This ensures that the all methods are consistent with the current flag. I think the getUnsafe could make sense but seems like a separate thing.
Captured this in https://issues.apache.org/jira/browse/ARROW-8738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm edited a comment on pull request #7095: ARROW-8664: [Java] Add flag to skip null check
Posted by GitBox <gi...@apache.org>.
wesm edited a comment on pull request #7095:
URL: https://github.com/apache/arrow/pull/7095#issuecomment-624685180
In the past adding a `getUnsafe` method was discussed. What do you think about that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jacques-n commented on pull request #7095: ARROW-8664: [Java] Add flag to skip null check
Posted by GitBox <gi...@apache.org>.
jacques-n commented on pull request #7095:
URL: https://github.com/apache/arrow/pull/7095#issuecomment-625579459
This looks good to me. +1.
> In the past adding a getUnsafe method was discussed. What do you think about that?
This ensures that the all methods are consistent with the current flag. I think the getUnsafe could make sense but seems like a separate thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7095: ARROW-8664: [Java] Add flag to skip null check
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7095:
URL: https://github.com/apache/arrow/pull/7095#issuecomment-624685180
In the last adding a `getUnsafe` method was discussed. What do you think about that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org