You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/02 10:00:15 UTC

[GitHub] [incubator-nuttx-apps] GUIDINGLI opened a new pull request #796: apps: add variable to identify main shell

GUIDINGLI opened a new pull request #796:
URL: https://github.com/apache/incubator-nuttx-apps/pull/796


   
   ## Summary
   
   apps: add variable to identify main shell
   
   This should be with
   https://github.com/apache/incubator-nuttx/pull/4042
   
   Root cause:
   
   These modify for shell ctrl + C usefulness when system() execute.
   
   1. execute 'cu' in shell front end, uart record 'cu' pid for later killing.
   2. one thread use system() to do sth anything, uart record new pid for later killing.
   3. ctrl +c can't kill 'cu' thread
   
   FIX:
   add param to nsh_newconsole() to identify the main shell & system cmd shell.
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #796: apps: add variable to identify main shell

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #796:
URL: https://github.com/apache/incubator-nuttx-apps/pull/796#issuecomment-873105448


   Yes, it still can be applied correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] davids5 merged pull request #796: apps: add variable to identify main shell

Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #796:
URL: https://github.com/apache/incubator-nuttx-apps/pull/796


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #796: apps: add variable to identify main shell

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #796:
URL: https://github.com/apache/incubator-nuttx-apps/pull/796#issuecomment-873073719


   @GUIDINGLI @xiaoxiang781216  is incubator-nuttx/boards/z16/z16f/z16f2800100zcog/tools/zneo-zdsii-5_0_1-variadic-func-fix.patch tested?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #796: apps: add variable to identify main shell

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #796:
URL: https://github.com/apache/incubator-nuttx-apps/pull/796#issuecomment-873096493


   Is that target built? Does the patch still apply cleanly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #796: apps: add variable to identify main shell

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #796:
URL: https://github.com/apache/incubator-nuttx-apps/pull/796#issuecomment-873094848


   zneo-zdsii-5_0_1-variadic-func-fix.patch add voutput callback, this patch add control tty. The chagne is unrelated and orthogonal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org