You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/08 05:48:24 UTC

[GitHub] [flink] wangyang0918 edited a comment on pull request #12003: [FLINK-10934] Support application mode for kubernetes

wangyang0918 edited a comment on pull request #12003:
URL: https://github.com/apache/flink/pull/12003#issuecomment-625642618


   @kl0u I am afraid that we could reuse`jarsOnClasspath` because it means the jar is located in the classpath. However, for K8s application, user could specify an arbitrary jar anywhere in the image. Maybe in the future we could remove `jarsOnClassPath` since we do not call `setJarsOnClassPath` in the production code.
   
    For `YarnApplicationClusterEntryPoint`, `KubernetesApplicationClusterEntrypoint `, `StandaloneJobClusterEntrypoint`, they have some similar logics about `getPackagedProgram` and `getPackagedProgramRetriever`. I agree with you that we could deduplicate them in the follow-ups.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org