[jira] [Commented] (CASSANDRA-14726) ReplicaCollection follow-up

["Benedict (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619343#comment-16619343 ] 

Benedict commented on CASSANDRA-14726:
--------------------------------------

Initial patch available [here|https://github.com/apache/cassandra/pull/271]

This introduces two internal classes: {{ReplicaList}} and {{ReplicaMap}} that permit more efficient implementation of {{AbstractReplicaCollection}}.  It also introduces a {{filterLazily}} method, and cleans up the caching (and use thereof) of transient/full sub collections in {{RangesAtEndpoint}}.

I'm also open to introducing any {{anyMatch}} and {{allMatch}} if people think it's a good idea.

It may be that this change is seen as unnecessary, but since these classes are all new, introducing these optimisations now seems like probably the best course of action.  I will follow up with some extra tests, though the new classes are *mostly* covered already through the existing tests.

> ReplicaCollection follow-up
> ---------------------------
>
>                 Key: CASSANDRA-14726
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14726
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Priority: Major
>
> We introduced \{{ReplicaCollection}} as part of CASSANDRA-14404, but while it improves readability, we could do more to ensure it minimises extra garbage, and does not otherwise unnecessarily waste cycles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org