You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2010/04/24 19:59:50 UTC

[jira] Resolved: (WICKET-2831) ConverterLocator#get(Class) shouldn't be final

     [ https://issues.apache.org/jira/browse/WICKET-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-2831.
-----------------------------------

      Assignee: Igor Vaynberg
    Resolution: Won't Fix

converterlocator.set and get maintain a contract we do not want broken thus both are final. use composition to create your own implementations.

> ConverterLocator#get(Class<T>) shouldn't be final
> -------------------------------------------------
>
>                 Key: WICKET-2831
>                 URL: https://issues.apache.org/jira/browse/WICKET-2831
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.4, 1.4.5, 1.4.6, 1.4.7
>            Reporter: Martín Bigio
>            Assignee: Igor Vaynberg
>             Fix For: 1.4.8
>
>
> ConverterLocator#get(Class<T>) shouldn't be final in order to let subclasses write a more sophisticated behaviour (like returning a superclass converter when requesting a converter for a class that doesn't have one registered). Also would be necessary to give protected visibility to DefaultConverter inner class.
> To walkthrough the problem composition can be used instead of inheritance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.