[GitHub] [mesos] cf-natali opened a new pull request #358: Mention that tests should be run as root/admin in contribution guides.

[GitBox <gi...@apache.org>]

cf-natali opened a new pull request #358: Mention that tests should be run as root/admin in contribution guides.
URL: https://github.com/apache/mesos/pull/358
 
 
   @abudnik 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mesos] bmahler commented on issue #358: Mention that tests should be run as root/admin in contribution guides.

[GitBox <gi...@apache.org>]

bmahler commented on issue #358: Mention that tests should be run as root/admin in contribution guides.
URL: https://github.com/apache/mesos/pull/358#issuecomment-614808981
 
 
   @abudnik perhaps we could be a bit more specific about when to run as root?
   
   We have a lot of test filters so it's a little more generalized (e.g. if you're touching a 'curl' related test make sure that runs, if touching a docker related test make sure that runs, etc): https://github.com/apache/mesos/blob/master/src/tests/environment.cpp
   
   I'm not sure we'll be able to write a good guideline here, other than just generally explaining how tests can be filtered for various reasons and then relying on contributors / reviewers / CI to make sure the appropriate ones are run.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services