You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by MLnick <gi...@git.apache.org> on 2018/01/29 10:04:29 UTC

[GitHub] spark pull request #20421: [SPARK-23112][DOC] Update ML migration guide with...

GitHub user MLnick opened a pull request:

    https://github.com/apache/spark/pull/20421

    [SPARK-23112][DOC] Update ML migration guide with breaking changes.

    Add breaking change note to ML migration guide.
    
    ## How was this patch tested?
    
    Doc only


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MLnick/spark SPARK-23112-ml-guide

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20421
    
----
commit 184d1133d1557211d8bb309883af60613c3e77fb
Author: Nick Pentreath <ni...@...>
Date:   2018-01-23T14:05:51Z

    Add highlights and migration guide for 2.3

commit cebc49613a179b318469d529df6d0a756ec59a2d
Author: Nick Pentreath <ni...@...>
Date:   2018-01-29T09:47:42Z

    Merge branch 'master' into SPARK-23112-ml-guide

commit b6fcf15dec51575bef0b1df787d57ba36b26ef63
Author: Nick Pentreath <ni...@...>
Date:   2018-01-29T10:02:24Z

    Update migration guide with breaking changes

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by WeichenXu123 <gi...@git.apache.org>.

Github user WeichenXu123 commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    @MLnick 
    Forget one fix: https://github.com/apache/spark/pull/18797
    I doubt whether this fix should go into "behavior change". It influences iteration number for algos use LBFGS, although it is a bugfix (this bug is introduced in spark 2.2).



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86808/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/371/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by MLnick <gi...@git.apache.org>.

Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Didn't this go into 2.2.1?
    
    On Wed, 31 Jan 2018 at 20:37 WeichenXu <no...@github.com> wrote:
    
    > @MLnick <https://github.com/mlnick>
    > Forget one fix: #18797 <https://github.com/apache/spark/pull/18797>
    > I doubt whether this fix should go into "behavior change". It influences
    > iteration number for algos use LBFGS, although it is a bugfix (this bug is
    > introduced in spark 2.2).
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/20421#issuecomment-362028022>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/AA_SB2_NZV3oDHuW4cVNnvutjYuldI0Eks5tQLL6gaJpZM4RwVo7>
    > .
    >



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86802/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    **[Test build #86808 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86808/testReport)** for PR 20421 at commit [`469d87d`](https://github.com/apache/spark/commit/469d87db6278da7f157d8e6c81e7a26c1b969e7c).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by WeichenXu123 <gi...@git.apache.org>.

Github user WeichenXu123 commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    ah, yes, it backport to 2.2 😳


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86767/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    **[Test build #86807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86807/testReport)** for PR 20421 at commit [`4a957f6`](https://github.com/apache/spark/commit/4a957f677eadfa5345a62f78b254c999869a1940).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by MLnick <gi...@git.apache.org>.

Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    @felixcheung just added a few more behavior changes I found. Should be final now.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86807/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    **[Test build #86767 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86767/testReport)** for PR 20421 at commit [`b6fcf15`](https://github.com/apache/spark/commit/b6fcf15dec51575bef0b1df787d57ba36b26ef63).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    **[Test build #86802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86802/testReport)** for PR 20421 at commit [`4433d9c`](https://github.com/apache/spark/commit/4433d9cb70bd7a3257aef4e23f8c85f57c7999a6).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by MLnick <gi...@git.apache.org>.

Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Merged to master / branch-2.3. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    **[Test build #86802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86802/testReport)** for PR 20421 at commit [`4433d9c`](https://github.com/apache/spark/commit/4433d9cb70bd7a3257aef4e23f8c85f57c7999a6).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    **[Test build #86807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86807/testReport)** for PR 20421 at commit [`4a957f6`](https://github.com/apache/spark/commit/4a957f677eadfa5345a62f78b254c999869a1940).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    **[Test build #86767 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86767/testReport)** for PR 20421 at commit [`b6fcf15`](https://github.com/apache/spark/commit/b6fcf15dec51575bef0b1df787d57ba36b26ef63).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/366/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20421: [SPARK-23112][DOC] Update ML migration guide with breaki...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20421
  
    **[Test build #86808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86808/testReport)** for PR 20421 at commit [`469d87d`](https://github.com/apache/spark/commit/469d87db6278da7f157d8e6c81e7a26c1b969e7c).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org