[GitHub] [druid] clintropolis commented on a diff in pull request #13051: improve nested column serializer

[GitBox <gi...@apache.org>]

clintropolis commented on code in PR #13051:
URL: https://github.com/apache/druid/pull/13051#discussion_r965495192


##########
processing/src/main/java/org/apache/druid/segment/nested/NestedDataColumnSerializer.java:
##########
@@ -398,17 +405,12 @@ void openColumnSerializer(String field, SegmentWriteOutMedium medium, int maxId)
       encodedValueSerializer.open();
     }
 
-    void serializeRow(int globalId, int localId) throws IOException
-    {
-      encodedValueSerializer.addValue(localId);
-    }
-
     long getSerializedColumnSize() throws IOException
     {
       return Integer.BYTES + Integer.BYTES + encodedValueSerializer.getSerializedSize();
     }
 
-    public void open() throws IOException
+    public void open(String field) throws IOException

Review Comment:
   this is getting used by the overrides for long and doubles, https://github.com/apache/druid/pull/13051/files#diff-79a5d0543cecca970d2986e5437ed90ab0964cefc89297a23698de2693e9f9b7R555



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org