[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4006: Cleanup Primitive take

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4006:
URL: https://github.com/apache/arrow-rs/pull/4006#discussion_r1155885605


##########
arrow-select/src/take.rs:
##########
@@ -252,19 +252,8 @@ where
 
 // take implementation when only values contain nulls
 fn take_values_nulls<T, I>(
-    values: &PrimitiveArray<T>,
-    indices: &[I],
-) -> Result<(Buffer, Option<Buffer>), ArrowError>
-where
-    T: ArrowPrimitiveType,
-    I: ArrowNativeType,
-{
-    take_values_nulls_inner(values.data(), values.values(), indices)

Review Comment:
   This indirection was added in https://github.com/apache/arrow-rs/pull/715, we can remove the additional indirection by parameterising the initial dispatch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org